diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-05-17 14:00:48 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-05-17 14:00:48 -0400 |
| commit | 413b49c2b6619a7ce16322c7f94079205031cda4 (patch) | |
| tree | 0784421d737876d900e539b9b5e3acca4f77b933 /gdb/cli/cli-decode.c | |
| parent | e683cb412046b40085505f42dd141f542661a6ae (diff) | |
| download | binutils-413b49c2b6619a7ce16322c7f94079205031cda4.zip binutils-413b49c2b6619a7ce16322c7f94079205031cda4.tar.gz binutils-413b49c2b6619a7ce16322c7f94079205031cda4.tar.bz2 | |
gdb: move cmd_list_element::prefixname to cli/cli-decode.c
I don't think this method really benefits from being implemented in the
header file, especially because it's recursive, it can't be inlined.
Move it to the source file, so it's no re-compiled by every CU
including cli/cli-decode.h.
I also noticed this method could be const, make it so.
gdb/ChangeLog:
* cli/cli-decode.h (prefixname): Make const, move implementation
to cli/cli-decode.c.
* cli/cli-decode.c (cmd_list_element::prefixname): New.
Change-Id: I1597cace98d9a4ba71f51f1f495e73cc07b5dcf3
Diffstat (limited to 'gdb/cli/cli-decode.c')
| -rw-r--r-- | gdb/cli/cli-decode.c | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c index 32edb52..a3b153f 100644 --- a/gdb/cli/cli-decode.c +++ b/gdb/cli/cli-decode.c @@ -160,6 +160,23 @@ set_cmd_completer_handle_brkchars (struct cmd_list_element *cmd, cmd->completer_handle_brkchars = func; } +std::string +cmd_list_element::prefixname () const +{ + if (this->prefixlist == nullptr) + /* Not a prefix command. */ + return ""; + + std::string prefixname; + if (this->prefix != nullptr) + prefixname = this->prefix->prefixname (); + + prefixname += this->name; + prefixname += " "; + + return prefixname; +} + /* Add element named NAME. Space for NAME and DOC must be allocated by the caller. CLASS is the top level category into which commands are broken down |