diff options
| author | Alan Modra <amodra@gmail.com> | 2020-09-01 07:48:02 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2020-09-01 16:03:08 +0930 |
| commit | 8dbe96f07060bc41499557d2837afbfffa1aa7fc (patch) | |
| tree | 236d23173e050e2ccc00e8456d9de5f2b63ec759 /cpu | |
| parent | 821e059c2626fb0b2ee91898b1c74ea9636c6175 (diff) | |
| download | binutils-8dbe96f07060bc41499557d2837afbfffa1aa7fc.zip binutils-8dbe96f07060bc41499557d2837afbfffa1aa7fc.tar.gz binutils-8dbe96f07060bc41499557d2837afbfffa1aa7fc.tar.bz2 | |
mep: ubsan: mep-ibld.c:1635,1645,1652 left shift of negative value
cpu/
* mep-core.cpu (f-8s8a2, f-12s4a2, f-17s16a2): Multiply signed
value by two rather than shifting left.
(f-24s5a2n): Similarly multiply signed f-24s5a2n-hi to extract.
opcodes/
* mep-ibld.c: Regenerate.
Diffstat (limited to 'cpu')
| -rw-r--r-- | cpu/ChangeLog | 6 | ||||
| -rw-r--r-- | cpu/mep-core.cpu | 10 |
2 files changed, 11 insertions, 5 deletions
diff --git a/cpu/ChangeLog b/cpu/ChangeLog index f810248..6609a05 100644 --- a/cpu/ChangeLog +++ b/cpu/ChangeLog @@ -1,3 +1,9 @@ +2020-09-01 Alan Modra <amodra@gmail.com> + + * mep-core.cpu (f-8s8a2, f-12s4a2, f-17s16a2): Multiply signed + value by two rather than shifting left. + (f-24s5a2n): Similarly multiply signed f-24s5a2n-hi to extract. + 2020-08-26 David Faust <david.faust@oracle.com> * bpf.cpu (arch bpf): Add xbpf mach and isas. diff --git a/cpu/mep-core.cpu b/cpu/mep-core.cpu index accf00e..bdc9c62 100644 --- a/cpu/mep-core.cpu +++ b/cpu/mep-core.cpu @@ -430,15 +430,15 @@ (df f-8s8a2 "pc-rel addr (8 bits)" (all-mep-core-isas PCREL-ADDR) 8 7 INT ((value pc) (sra SI (sub SI value pc) 1)) - ((value pc) (add SI (sll SI value 1) pc))) + ((value pc) (add SI (mul SI value 2) pc))) (df f-12s4a2 "pc-rel addr (12 bits)" (all-mep-core-isas PCREL-ADDR) 4 11 INT ((value pc) (sra SI (sub SI value pc) 1)) - ((value pc) (add SI (sll SI value 1) pc))) + ((value pc) (add SI (mul SI value 2) pc))) (df f-17s16a2 "pc-rel addr (17 bits)" (all-mep-core-isas PCREL-ADDR) 16 16 INT ((value pc) (sra SI (sub SI value pc) 1)) - ((value pc) (add SI (sll SI value 1) pc))) + ((value pc) (add SI (mul SI value 2) pc))) (df f-24s5a2n-hi "24s5a2n hi 16s16" (all-mep-core-isas PCREL-ADDR) 16 16 INT #f #f) (df f-24s5a2n-lo "24s5a2n lo 7s5a2" (all-mep-core-isas PCREL-ADDR) 5 7 UINT #f #f) @@ -456,7 +456,7 @@ (set (ifield f-24s5a2n-hi) (sra INT (ifield f-24s5a2n) 8)))) (extract (set (ifield f-24s5a2n) - (add SI (or (sll (ifield f-24s5a2n-hi) 8) + (add SI (or (mul (ifield f-24s5a2n-hi) 256) (sll (ifield f-24s5a2n-lo) 1)) pc))) ) @@ -486,7 +486,7 @@ (df f-7u9 "tp-rel b (7 bits)" (all-mep-core-isas) 9 7 UINT #f #f) (df f-7u9a2 "tp-rel h (7 bits)" (all-mep-core-isas) 9 6 UINT ((value pc) (srl SI value 1)) - ((value pc) (sll SI value 1))) + ((value pc) (mul SI value 2))) (df f-7u9a4 "tp/sp-rel w (7 bits)" (all-mep-core-isas) 9 5 UINT ((value pc) (srl SI value 2)) ((value pc) (sll SI value 2))) |