diff options
author | Gaius Mulley <gaiusmod2@gmail.com> | 2020-08-25 09:39:27 +0100 |
---|---|---|
committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2020-08-25 10:28:06 +0100 |
commit | 3945d2d77e373c828ebbbb05b3ba06adf39019ab (patch) | |
tree | 99bf6cac80354c51f7d533e4cfb972b6a7a39692 /binutils/objcopy.c | |
parent | 419cca029e5d4b9b648402f9da3c38f302ca7b0a (diff) | |
download | binutils-3945d2d77e373c828ebbbb05b3ba06adf39019ab.zip binutils-3945d2d77e373c828ebbbb05b3ba06adf39019ab.tar.gz binutils-3945d2d77e373c828ebbbb05b3ba06adf39019ab.tar.bz2 |
gdb/modula-2: parsing of multi-subscript arrays
Fix bug PR m2/26372, GDB's inability to parse multi-dimensional
modula-2 arrays.
We previously had two rules for handling the parsing of array
sub-scripts. I have reproduced them here with the actual handler
blocks removed to make the bug clearer:
exp : exp '[' non_empty_arglist ']'
;
exp : exp '[' exp ']'
;
non_empty_arglist
: exp
;
non_empty_arglist
: non_empty_arglist ',' exp
;
This is ambiguous as the pattern "exp '[' exp" could match either of
the 'exp' rules. Currently it just so happens that the parser picks
the second 'exp' rule which means we can only handle a single array
index.
As the handler code for the first 'exp' pattern will correctly handle
and number of array indexes then lets just remove the second pattern.
gdb/ChangeLog:
PR m2/26372
* m2-exp.y (exp): Improve comment for non_empty_arglist case, add
an assert. Remove single element array indexing pattern as the
MULTI_SUBSCRIPT support will handle this case too.
gdb/testsuite/ChangeLog:
PR m2/26372
* gdb.modula2/multidim.c: New file.
* gdb.modula2/multidim.exp: New file.
Diffstat (limited to 'binutils/objcopy.c')
0 files changed, 0 insertions, 0 deletions