diff options
| author | Tom de Vries <tdevries@suse.de> | 2019-07-29 16:24:57 +0200 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2019-07-29 16:24:57 +0200 |
| commit | de28a3b72e4e85233c6ece9063696b13ef170c00 (patch) | |
| tree | 4b66a34e1c360184135754339b44d31513e7ee39 | |
| parent | 507dd60e28d0ef35ffb7c0880933d6b88cc3f5bd (diff) | |
| download | binutils-de28a3b72e4e85233c6ece9063696b13ef170c00.zip binutils-de28a3b72e4e85233c6ece9063696b13ef170c00.tar.gz binutils-de28a3b72e4e85233c6ece9063696b13ef170c00.tar.bz2 | |
[gdb/testsuite, 2/2] Fix gdb.linespec/explicit.exp with check-read1
When running gdb.linespec/explicit.exp with check-read1, we get:
...
(gdb) PASS: gdb.linespec/explicit.exp: set max-completions unlimited
break
-function
...
top
(gdb) PASS: gdb.linespec/explicit.exp: complete with no arguments
break
-function
...
top
(gdb) FAIL: gdb.linespec/explicit.exp: complete with no arguments (clearing input line)
...
The problem is that the send_gdb "\t\t" triggers completion twice:
...
set tst "complete with no arguments"
send_gdb "break \t"
gdb_test_multiple "" $tst {
"break \\\x07" {
send_gdb "\t\t"
gdb_test_multiple "" $tst {
...
}
clear_input_line $tst
...
but the following gdb_test_multiple only parses it once, so the second
completion is left for clear_input_line, which fails.
Fix this by triggering completion only once.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2019-07-29 Tom de Vries <tdevries@suse.de>
* gdb.linespec/explicit.exp: Fix completion trigger for "complete with
no arguments".
| -rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.linespec/explicit.exp | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 498f4e4..e29c267 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2019-07-29 Tom de Vries <tdevries@suse.de> + * gdb.linespec/explicit.exp: Fix completion trigger for "complete with + no arguments". + +2019-07-29 Tom de Vries <tdevries@suse.de> + * gdb.linespec/explicit.exp: Fix gdb_test_multiple regexps where second is a substring of the first for "complete non-unique file name". diff --git a/gdb/testsuite/gdb.linespec/explicit.exp b/gdb/testsuite/gdb.linespec/explicit.exp index 90181b3..e50e503 100644 --- a/gdb/testsuite/gdb.linespec/explicit.exp +++ b/gdb/testsuite/gdb.linespec/explicit.exp @@ -473,7 +473,7 @@ namespace eval $testfile { send_gdb "break \t" gdb_test_multiple "" $tst { "break \\\x07" { - send_gdb "\t\t" + send_gdb "\t" gdb_test_multiple "" $tst { "Display all" { send_gdb "y" |