diff options
| author | Tom de Vries <tdevries@suse.de> | 2024-05-04 10:41:09 +0200 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2024-05-04 10:41:09 +0200 |
| commit | c42c12f9bf93b5f10f3d6dc10f45d9484a7f9faa (patch) | |
| tree | ba21e1d71b15b19b0fc505c40102d27296402772 | |
| parent | b6dfea2438b61116f7883926b3a3819277788752 (diff) | |
| download | binutils-c42c12f9bf93b5f10f3d6dc10f45d9484a7f9faa.zip binutils-c42c12f9bf93b5f10f3d6dc10f45d9484a7f9faa.tar.gz binutils-c42c12f9bf93b5f10f3d6dc10f45d9484a7f9faa.tar.bz2 | |
[gdb/testsuite] Make portnum a persistent global
When instrumenting get_portnum using:
...
puts "PORTNUM: $res"
...
and running:
...
$ cd build/gdb
$ make check TESTS=gdb.server/*.exp
...
we get:
...
Running gdb.server/target-exec-file.exp ...
PORTNUM: 2345
Running gdb.server/stop-reply-no-thread-multi.exp ...
PORTNUM: 2345
PORTNUM: 2346
PORTNUM: 2347
PORTNUM: 2348
PORTNUM: 2349
PORTNUM: 2350
...
So, while get_portnum does return increasing numbers in a single test-case, it
restarts at each test-case.
This is a regression since the introduction of persistent globals.
Fix this by using "gdb_persistent_global portnum", such that we get:
...
Running gdb.server/target-exec-file.exp ...
PORTNUM: 2345
Running gdb.server/stop-reply-no-thread-multi.exp ...
PORTNUM: 2346
PORTNUM: 2347
PORTNUM: 2348
PORTNUM: 2349
PORTNUM: 2350
PORTNUM: 2351
...
Tested on aarch64-linux.
Approved-By: Tom Tromey <tom@tromey.com>
| -rw-r--r-- | gdb/testsuite/lib/gdbserver-support.exp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp index bf00011..0f97ce9 100644 --- a/gdb/testsuite/lib/gdbserver-support.exp +++ b/gdb/testsuite/lib/gdbserver-support.exp @@ -142,7 +142,7 @@ proc get_portnum {} { set initial_portnum 2345 # Currently available port number. - global portnum + gdb_persistent_global portnum # Initialize, if necessary. if { ![info exists portnum] } { |