diff options
| author | Tom Tromey <tromey@adacore.com> | 2022-02-16 12:33:45 -0700 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2022-03-07 08:27:38 -0700 |
| commit | aacf24b4db3422632d6b62d473faf71f4e737072 (patch) | |
| tree | e9eb89f6b38799c82634bd6d664eb0c6fa1b7202 | |
| parent | 63fc2437deda87a566059444630ccc402945ae99 (diff) | |
| download | binutils-aacf24b4db3422632d6b62d473faf71f4e737072.zip binutils-aacf24b4db3422632d6b62d473faf71f4e737072.tar.gz binutils-aacf24b4db3422632d6b62d473faf71f4e737072.tar.bz2 | |
Fix bug in ada_print_floating
ada_print_floating rewrites a floating-point string representation to
conform to Ada syntax. However, if you managed to get a floating
point error, you might see:
(gdb) print whatever
$2 = <invalid float valu.0e>
What's happening here is that ada_print_floating doesn't recognize
this error case, and proceeds to modify the error text.
This patch fixes this problem.
| -rw-r--r-- | gdb/ada-valprint.c | 7 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.ada/float-bits.exp | 3 |
2 files changed, 10 insertions, 0 deletions
diff --git a/gdb/ada-valprint.c b/gdb/ada-valprint.c index bf95719..e113088 100644 --- a/gdb/ada-valprint.c +++ b/gdb/ada-valprint.c @@ -314,6 +314,13 @@ ada_print_floating (const gdb_byte *valaddr, struct type *type, std::string s = tmp_stream.release (); size_t skip_count = 0; + /* Don't try to modify a result representing an error. */ + if (s[0] == '<') + { + fputs_filtered (s.c_str (), stream); + return; + } + /* Modify for Ada rules. */ size_t pos = s.find ("inf"); diff --git a/gdb/testsuite/gdb.ada/float-bits.exp b/gdb/testsuite/gdb.ada/float-bits.exp index 61db5f3..c98afb5 100644 --- a/gdb/testsuite/gdb.ada/float-bits.exp +++ b/gdb/testsuite/gdb.ada/float-bits.exp @@ -48,3 +48,6 @@ gdb_test "print val_long_double := 16llf#7FFFF7FF4054A56FA5B99019A5C8#" \ " = 5.0e\\+25" gdb_test "print val_long_double" " = 5.0e\\+25" \ "print val_long_double after assignment" + +gdb_test "print 16llf#a56fa5b99019a5c800007ffff7ff4054#" \ + " = <invalid float value>" |