diff options
| author | Tom de Vries <tdevries@suse.de> | 2018-10-31 16:33:46 +0100 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2018-10-31 17:45:38 +0100 |
| commit | 1443936e967d4a0a49acb8756e3f808dc3628318 (patch) | |
| tree | a2c8a43d21082cb953a0b6d8c90feb4e2d7e61ff | |
| parent | f32a4a593963d4c377fd59f4164c9df2cd6a7590 (diff) | |
| download | binutils-1443936e967d4a0a49acb8756e3f808dc3628318.zip binutils-1443936e967d4a0a49acb8756e3f808dc3628318.tar.gz binutils-1443936e967d4a0a49acb8756e3f808dc3628318.tar.bz2 | |
[gdb/testsuite] get_valueof: Don't output value in test name
The get_valueof outputs the value it has read as part of the test name. This
causes test names to vary from run to run, and adds some noise when diffing
test results. e.g.:
-PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" (140737488343920)
+PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" (140737488343968)
-PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" (140737488343920)
+PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" (140737488343968)
This patch removes that, since it's probably not very useful.
Tested on x86_64-linux.
2018-10-31 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (get_valueof): Don't output read value in test name.
| -rw-r--r-- | gdb/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/testsuite/lib/gdb.exp | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8fa6b0d..2f0085b 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2018-10-31 Tom de Vries <tdevries@suse.de> + + * lib/gdb.exp (get_valueof): Don't output read value in test name. + 2018-10-31 Andrew Burgess <andrew.burgess@embecosm.com> * gdb.dwarf2/void-type.c: New file. diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index b4cf80e..5a5713b 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5636,7 +5636,7 @@ proc get_valueof { fmt exp default {test ""} } { gdb_test_multiple "print${fmt} ${exp}" "$test" { -re "\\$\[0-9\]* = (\[^\r\n\]*)\[\r\n\]*$gdb_prompt $" { set val $expect_out(1,string) - pass "$test ($val)" + pass "$test" } timeout { fail "$test (timeout)" |