aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Metzger <markus.t.metzger@intel.com>2024-02-23 07:07:39 +0000
committerMarkus Metzger <markus.t.metzger@intel.com>2025-05-26 07:00:43 +0000
commita93443f5c22fb751d157741559f4122123aeabad (patch)
treebb3875ff60ff8ac1e536f82c05ae5ded0d9a52d3
parent95d54e0c6e4c558e8f39c0167221e81b0eec6069 (diff)
downloadbinutils-a93443f5c22fb751d157741559f4122123aeabad.zip
binutils-a93443f5c22fb751d157741559f4122123aeabad.tar.gz
binutils-a93443f5c22fb751d157741559f4122123aeabad.tar.bz2
gdb, btrace: remove record_btrace_target::supports_*()
Let's not introduce support for breakpoint types the target beneath does not support, even though we could while replaying. Otherwise, users may set breakpoints during replay that then couldn't be inserted into the target when switching back to recording. Approved-By: Andrew Burgess <aburgess@redhat.com>
-rw-r--r--gdb/record-btrace.c27
1 files changed, 0 insertions, 27 deletions
diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
index 2d71b72..19cd576 100644
--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -132,10 +132,7 @@ public:
bool can_execute_reverse () override;
bool stopped_by_sw_breakpoint () override;
- bool supports_stopped_by_sw_breakpoint () override;
-
bool stopped_by_hw_breakpoint () override;
- bool supports_stopped_by_hw_breakpoint () override;
enum exec_direction_kind execution_direction () override;
void prepare_to_generate_core () override;
@@ -2773,18 +2770,6 @@ record_btrace_target::stopped_by_sw_breakpoint ()
return this->beneath ()->stopped_by_sw_breakpoint ();
}
-/* The supports_stopped_by_sw_breakpoint method of target
- record-btrace. */
-
-bool
-record_btrace_target::supports_stopped_by_sw_breakpoint ()
-{
- if (record_is_replaying (minus_one_ptid))
- return true;
-
- return this->beneath ()->supports_stopped_by_sw_breakpoint ();
-}
-
/* The stopped_by_sw_breakpoint method of target record-btrace. */
bool
@@ -2800,18 +2785,6 @@ record_btrace_target::stopped_by_hw_breakpoint ()
return this->beneath ()->stopped_by_hw_breakpoint ();
}
-/* The supports_stopped_by_hw_breakpoint method of target
- record-btrace. */
-
-bool
-record_btrace_target::supports_stopped_by_hw_breakpoint ()
-{
- if (record_is_replaying (minus_one_ptid))
- return true;
-
- return this->beneath ()->supports_stopped_by_hw_breakpoint ();
-}
-
/* The update_thread_list method of target record-btrace. */
void