diff options
author | Bernhard Heckel <bernhard.heckel@intel.com> | 2016-06-30 14:11:03 +0200 |
---|---|---|
committer | Bernhard Heckel <bernhard.heckel@intel.com> | 2016-12-23 12:20:04 +0100 |
commit | 671c004cc4dcd29606641ea1caee663905a9dcff (patch) | |
tree | de5c88086d4e6e78b7df75e6acafd485dbd8146e | |
parent | 57ed8b65ccd5ab8391a83d064e0bca5301ff0f94 (diff) | |
download | binutils-671c004cc4dcd29606641ea1caee663905a9dcff.zip binutils-671c004cc4dcd29606641ea1caee663905a9dcff.tar.gz binutils-671c004cc4dcd29606641ea1caee663905a9dcff.tar.bz2 |
Fortran: Enable setting breakpoint on nested functions.
Like in Ada, we want to be able to set a breakpoint on
nested functions, called "contained routines" in Fortran.
2016-06-30 Bernhard Heckel <bernhard.heckel@intel.com>
gdb/Changelog:
* dwarf2read.c (todo)
gdb/Changelog:
* gdb.fortran/nested-funcs.exp: Set breakpoint on contained routines.
Change-Id: I7f2897f8f3160c0d5618850273d87579cc2479c8
-rw-r--r-- | gdb/dwarf2read.c | 9 | ||||
-rwxr-xr-x | gdb/testsuite/gdb.fortran/nested-funcs.exp | 8 |
2 files changed, 15 insertions, 2 deletions
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 945ca61..cba551d 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -6936,7 +6936,9 @@ add_partial_symbol (struct partial_die_info *pdi, struct dwarf2_cu *cu) break; case DW_TAG_subprogram: addr = gdbarch_adjust_dwarf2_addr (gdbarch, pdi->lowpc + baseaddr); - if (pdi->is_external || cu->language == language_ada) + if (pdi->is_external + || cu->language == language_ada + || cu->language == language_fortran) { /* brobecker/2007-12-26: Normally, only "external" DIEs are part of the global scope. But in Ada, we want to be able to access @@ -7219,6 +7221,8 @@ add_partial_subprogram (struct partial_die_info *pdi, { if (pdi->tag == DW_TAG_entry_point) add_partial_entry_point (pdi, lowpc, highpc, set_addrmap, cu); + else if (pdi->tag == DW_TAG_subprogram) + add_partial_subprogram (pdi, lowpc, highpc, set_addrmap, cu); pdi = pdi->die_sibling; } } @@ -18530,7 +18534,8 @@ new_symbol_full (struct die_info *die, struct type *type, struct dwarf2_cu *cu, SYMBOL_ACLASS_INDEX (sym) = LOC_BLOCK; attr2 = dwarf2_attr (die, DW_AT_external, cu); if ((attr2 && (DW_UNSND (attr2) != 0)) - || cu->language == language_ada) + || cu->language == language_ada + || cu->language == language_fortran) { /* Subprograms marked external are stored as a global symbol. Ada subprograms, whether marked external or not, are always diff --git a/gdb/testsuite/gdb.fortran/nested-funcs.exp b/gdb/testsuite/gdb.fortran/nested-funcs.exp index 976aa22..d098ba1 100755 --- a/gdb/testsuite/gdb.fortran/nested-funcs.exp +++ b/gdb/testsuite/gdb.fortran/nested-funcs.exp @@ -30,6 +30,10 @@ if ![runto MAIN__] then { continue
}
+# Test if we can set a breakpoint in a nested function
+gdb_breakpoint "sub_nested_outer"
+gdb_continue_to_breakpoint "sub_nested_outer" ".*local_int = 19"
+
# Test if we can access local and
# non-local variables defined one level up.
gdb_breakpoint [gdb_get_line_number "! BP_outer"]
@@ -43,6 +47,10 @@ gdb_test "print local_int" "= 19" "print local_int in outer function" gdb_test "up"
gdb_test "print index" "= 42" "print index at BP1, one frame up"
+# Test if we can set a breakpoint in a nested function
+gdb_breakpoint "sub_nested_inner"
+gdb_continue_to_breakpoint "sub_nested_inner" ".*local_int = 17"
+
# Test if we can access local and
# non-local variables defined two level up.
gdb_breakpoint [gdb_get_line_number "! BP_inner"]
|