aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2023-08-02 07:53:26 +0930
committerAlan Modra <amodra@gmail.com>2023-08-02 07:53:26 +0930
commitb6456e91d40fd38db264db26991c99381a3da5e6 (patch)
tree9ee6b79df08ab704006f69d6ea3e606d383d3d49
parent665b41c0ce13ab2f9df18881a699c5e896e906f2 (diff)
downloadbinutils-b6456e91d40fd38db264db26991c99381a3da5e6.zip
binutils-b6456e91d40fd38db264db26991c99381a3da5e6.tar.gz
binutils-b6456e91d40fd38db264db26991c99381a3da5e6.tar.bz2
Don't declare xmalloc or xrealloc in bucomm.h
It's better to include the proper header, which has declarations with various attributes. Commit 096aefc040 in 1994 introduced this wart. * bucomm.h (xmalloc, xrealloc): Delete declaration. * od-macho.c: Include libiberty.h. * od-xcoff.c: Include libiberty.h.
-rw-r--r--binutils/bucomm.h6
-rw-r--r--binutils/od-macho.c1
-rw-r--r--binutils/od-xcoff.c1
3 files changed, 2 insertions, 6 deletions
diff --git a/binutils/bucomm.h b/binutils/bucomm.h
index 0c11c0b..b708790 100644
--- a/binutils/bucomm.h
+++ b/binutils/bucomm.h
@@ -76,12 +76,6 @@ extern void set_times (const char *, const struct stat *);
extern int smart_rename (const char *, const char *, int,
struct stat *, bool);
-
-/* In libiberty. */
-void *xmalloc (size_t);
-
-void *xrealloc (void *, size_t);
-
#if __GNUC__ >= 7
#define _mul_overflow(a, b, res) __builtin_mul_overflow (a, b, res)
#else
diff --git a/binutils/od-macho.c b/binutils/od-macho.c
index 17253d4..c2bd7d3 100644
--- a/binutils/od-macho.c
+++ b/binutils/od-macho.c
@@ -23,6 +23,7 @@
#include <stddef.h>
#include <time.h>
#include "safe-ctype.h"
+#include "libiberty.h"
#include "bfd.h"
#include "objdump.h"
#include "bucomm.h"
diff --git a/binutils/od-xcoff.c b/binutils/od-xcoff.c
index 92d17e9..e6b2f08 100644
--- a/binutils/od-xcoff.c
+++ b/binutils/od-xcoff.c
@@ -23,6 +23,7 @@
#include <stddef.h>
#include <time.h>
#include "safe-ctype.h"
+#include "libiberty.h"
#include "bfd.h"
#include "objdump.h"
#include "bucomm.h"