Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
scan-build generates the following warning:
../../libjaylink/discovery.c:234:21: warning: Assigned value is garbage or undefined
dev->serial_number = serial_number;
The variable 'serial_number' is not initialized if the device has no
valid serial number. This is not a real issue because the variable will
never be accessed if the device has no valid serial number.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Thanks to Uwe Bonnes for reporting this.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Do not determine the Git revision hash from the repository in the
current working directory because, in some circumstances, the revision
hash of a commit from a different repository is used. For example, this
happens when 'configure' is called from within an other Git repository.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Cover all possible error codes which may be returned by a device.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
The README file is always automatically distributed.
For more information, see:
https://www.gnu.org/software/automake/manual/html_node/Basics-of-Distribution.html
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Do not assign user variables (e.g. CFLAGS) in configure.ac, otherwise
users are not able to modify them properly at 'make' and 'configure'
invocation time.
For more information, see:
https://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html
Thanks to Paul Fertser for spotting this.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
If necessary, a more general identifier which denotes the last element
of an enum may be re-added later.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Append the short Git revision hash of the current commit to the package
version if there is no release tag for the package version on it and Git
is available.
This makes the package version more informative and allows the
distinction between development and release versions.
This code is inspired by, but not derived from, a patch from Daniel
Elstner for the libsigrok project.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
The device expects that the trace data is read even if the status
code indicates an error.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Use a human-readable error description rather than just the error
code in log messages.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Currently, the functions jaylink_select_interface() and
jaylink_get_selected_interface() check if the target interface value
returned by a device is covered by an enum. If this is not the case they
fail with an error.
This approach is very restrictive and may stop applications from
working when using devices with target interfaces or other values which
are not covered by an enum. It also requires to update libjaylink every
time a new value is introduced. This could occur with every update of
the device firmware. In the mean time applications would fail with such
devices.
Also, using this approach for jaylink_get_hardware_version() would make
it impossible to retrieve the hardware version number of a device with
a hardware type which is not yet covered by an enum. In the worst case
an application would fail because jaylink_get_hardware_version() fails
even though the application does not use the hardware type at all but
the hardware version.
Do not catch values returned by a device and not covered by an enum to
overcome these problems. Instead, add a warning to the documentation of
all functions which may return such values.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
The additional information provided by jaylink_(un)register() is not yet
documented and not at all necessary to (un)register a connection. Also,
the API in its current state is not well thought out.
Remove access to the additional information in favour of a simpler API.
If necessary, the access may be re-added with a proper documentation and
well thought out API in a future version.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Instead of representing the IPv4 address as 32-bit integer, use the
much more convenient quad-dotted decimal string representation.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Foolishly, 'interface' is a reserved keyword on Windows according to
MSDN:
https://msdn.microsoft.com/en-us/library/2kb28261.aspx
Rename all 'interface' identifiers in the public API to avoid possible
conflicts.
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|
|
Signed-off-by: Marc Schink <jaylink-dev@marcschink.de>
|