diff options
author | Andrew Waterman <andrew@sifive.com> | 2021-09-17 19:10:11 -0700 |
---|---|---|
committer | Andrew Waterman <andrew@sifive.com> | 2021-09-17 19:10:11 -0700 |
commit | 22affb92b73a383115d22b0c85da1564e09a7f7b (patch) | |
tree | 621042df524dc306be724d273a74f5dc2e13dece | |
parent | b4f76106d241311788082207ca0ac9028564accd (diff) | |
download | spike-22affb92b73a383115d22b0c85da1564e09a7f7b.zip spike-22affb92b73a383115d22b0c85da1564e09a7f7b.tar.gz spike-22affb92b73a383115d22b0c85da1564e09a7f7b.tar.bz2 |
Use RIAA pattern in manipulating ostream flags
sout is renamed to sout_ to reduce likelihood programmers accidentally use it.
-rw-r--r-- | riscv/interactive.cc | 83 | ||||
-rw-r--r-- | riscv/processor.cc | 14 | ||||
-rw-r--r-- | riscv/processor.h | 4 | ||||
-rw-r--r-- | riscv/sim.cc | 6 | ||||
-rw-r--r-- | riscv/sim.h | 2 | ||||
-rw-r--r-- | spike_main/spike-log-parser.cc | 2 |
6 files changed, 66 insertions, 45 deletions
diff --git a/riscv/interactive.cc b/riscv/interactive.cc index a638a4c..31ac77d 100644 --- a/riscv/interactive.cc +++ b/riscv/interactive.cc @@ -100,17 +100,17 @@ std::string sim_t::rin(streambuf *bout_ptr) { cerr << e.what() << endl; } // output goes to socket - sout.rdbuf(bout_ptr); + sout_.rdbuf(bout_ptr); } else { // if we are not listening on a socket, get commands from terminal cerr << ": " << std::flush; s = readline(2); // 2 is stderr, but when doing reads it reverts to stdin // output goes to stderr - sout.rdbuf(cerr.rdbuf()); + sout_.rdbuf(cerr.rdbuf()); } return s; } -// write sout to socket (via bout) +// write sout_ to socket (via bout) void sim_t::wout(streambuf *bout_ptr) { if (!cmd_file && acceptor_ptr) { // only if we are not getting command inputs from a file // and if a socket has been created @@ -164,7 +164,7 @@ void sim_t::interactive() // up to MAX_CMD_STR characters before \n, skipping \n s = cmd_str; // while we get input from file, output goes to stderr - sout.rdbuf(cerr.rdbuf()); + sout_.rdbuf(cerr.rdbuf()); } else { // when there are no commands left from file or if there was no file from the beginning cmd_file = NULL; // mark file pointer as being not valid, so any method can test this easily @@ -193,15 +193,16 @@ void sim_t::interactive() while (ss >> tmp) args.push_back(tmp); + ostream out(sout_.rdbuf()); + try { if (funcs.count(cmd)) (this->*funcs[cmd])(cmd, args); else - sout << "Unknown command " << cmd << endl; - } - catch(trap_t& t) { - sout << "Bad or missing arguments for command " << cmd << endl; + out << "Unknown command " << cmd << endl; + } catch(trap_t& t) { + out << "Bad or missing arguments for command " << cmd << endl; } #ifdef HAVE_BOOST_ASIO wout(&bout); // socket output, if required @@ -212,7 +213,8 @@ void sim_t::interactive() void sim_t::interactive_help(const std::string& cmd, const std::vector<std::string>& args) { - sout << + ostream out(sout_.rdbuf()); + out << "Interactive commands:\n" "reg <core> [reg] # Display [reg] (all if omitted) in <core>\n" "freg <core> <reg> # Display float <reg> in <core> as hex\n" @@ -258,7 +260,9 @@ void sim_t::interactive_run(const std::string& cmd, const std::vector<std::strin set_procs_debug(noisy); for (size_t i = 0; i < steps && !ctrlc_pressed && !done(); i++) step(1); - if (!noisy) sout << ":" << endl; + + ostream out(sout_.rdbuf()); + if (!noisy) out << ":" << endl; } void sim_t::interactive_quit(const std::string& cmd, const std::vector<std::string>& args) @@ -282,8 +286,10 @@ void sim_t::interactive_pc(const std::string& cmd, const std::vector<std::string processor_t *p = get_core(args[0]); int max_xlen = p->get_max_xlen(); - sout << hex << setfill('0') << "0x" << setw(max_xlen/4) - << zext(get_pc(args), max_xlen) << endl; + + ostream out(sout_.rdbuf()); + out << hex << setfill('0') << "0x" << setw(max_xlen/4) + << zext(get_pc(args), max_xlen) << endl; } reg_t sim_t::get_reg(const std::vector<std::string>& args) @@ -347,32 +353,34 @@ void sim_t::interactive_vreg(const std::string& cmd, const std::vector<std::stri const int vlen = (int)(p->VU.get_vlen()) >> 3; const int elen = (int)(p->VU.get_elen()) >> 3; const int num_elem = vlen/elen; - sout << dec << "VLEN=" << (vlen << 3) << " bits; ELEN=" << (elen << 3) << " bits" << endl; + + ostream out(sout_.rdbuf()); + out << dec << "VLEN=" << (vlen << 3) << " bits; ELEN=" << (elen << 3) << " bits" << endl; for (int r = rstart; r < rend; ++r) { - sout << setfill (' ') << left << setw(4) << vr_name[r] << right << ": "; + out << setfill (' ') << left << setw(4) << vr_name[r] << right << ": "; for (int e = num_elem-1; e >= 0; --e){ uint64_t val; switch(elen){ case 8: val = P.VU.elt<uint64_t>(r, e); - sout << dec << "[" << e << "]: 0x" << hex << setfill ('0') << setw(16) << val << " "; + out << dec << "[" << e << "]: 0x" << hex << setfill ('0') << setw(16) << val << " "; break; case 4: val = P.VU.elt<uint32_t>(r, e); - sout << dec << "[" << e << "]: 0x" << hex << setfill ('0') << setw(8) << (uint32_t)val << " "; + out << dec << "[" << e << "]: 0x" << hex << setfill ('0') << setw(8) << (uint32_t)val << " "; break; case 2: val = P.VU.elt<uint16_t>(r, e); - sout << dec << "[" << e << "]: 0x" << hex << setfill ('0') << setw(8) << (uint16_t)val << " "; + out << dec << "[" << e << "]: 0x" << hex << setfill ('0') << setw(8) << (uint16_t)val << " "; break; case 1: val = P.VU.elt<uint8_t>(r, e); - sout << dec << "[" << e << "]: 0x" << hex << setfill ('0') << setw(8) << (int)(uint8_t)val << " "; + out << dec << "[" << e << "]: 0x" << hex << setfill ('0') << setw(8) << (int)(uint8_t)val << " "; break; } } - sout << endl; + out << endl; } } @@ -385,19 +393,21 @@ void sim_t::interactive_reg(const std::string& cmd, const std::vector<std::strin processor_t *p = get_core(args[0]); int max_xlen = p->get_max_xlen(); + ostream out(sout_.rdbuf()); + out << hex; + if (args.size() == 1) { // Show all the regs! - sout << hex; for (int r = 0; r < NXPR; ++r) { - sout << setfill(' ') << setw(4) << xpr_name[r] + out << setfill(' ') << setw(4) << xpr_name[r] << ": 0x" << setfill('0') << setw(max_xlen/4) << zext(p->get_state()->XPR[r], max_xlen); if ((r + 1) % 4 == 0) - sout << endl; + out << endl; } } else { - sout << "0x" << setfill('0') << setw(max_xlen/4) + out << "0x" << setfill('0') << setw(max_xlen/4) << zext(get_reg(args), max_xlen) << endl; } } @@ -412,28 +422,36 @@ union fpr void sim_t::interactive_freg(const std::string& cmd, const std::vector<std::string>& args) { freg_t r = get_freg(args); - sout << hex << "0x" << setfill ('0') << setw(16) << r.v[1] << setw(16) << r.v[0] << endl; + + ostream out(sout_.rdbuf()); + out << hex << "0x" << setfill ('0') << setw(16) << r.v[1] << setw(16) << r.v[0] << endl; } void sim_t::interactive_fregh(const std::string& cmd, const std::vector<std::string>& args) { fpr f; f.r = freg(f16_to_f32(f16(get_freg(args)))); - sout << dec << (isBoxedF32(f.r) ? (double)f.s : NAN) << endl; + + ostream out(sout_.rdbuf()); + out << dec << (isBoxedF32(f.r) ? (double)f.s : NAN) << endl; } void sim_t::interactive_fregs(const std::string& cmd, const std::vector<std::string>& args) { fpr f; f.r = get_freg(args); - sout << dec << (isBoxedF32(f.r) ? (double)f.s : NAN) << endl; + + ostream out(sout_.rdbuf()); + out << dec << (isBoxedF32(f.r) ? (double)f.s : NAN) << endl; } void sim_t::interactive_fregd(const std::string& cmd, const std::vector<std::string>& args) { fpr f; f.r = get_freg(args); - sout << dec << (isBoxedF64(f.r) ? f.d : NAN) << endl; + + ostream out(sout_.rdbuf()); + out << dec << (isBoxedF64(f.r) ? f.d : NAN) << endl; } reg_t sim_t::get_mem(const std::vector<std::string>& args) @@ -477,8 +495,9 @@ void sim_t::interactive_mem(const std::string& cmd, const std::vector<std::strin { int max_xlen = procs[0]->get_max_xlen(); - sout << hex << "0x" << setfill('0') << setw(max_xlen/4) - << zext(get_mem(args), max_xlen) << endl; + ostream out(sout_.rdbuf()); + out << hex << "0x" << setfill('0') << setw(max_xlen/4) + << zext(get_mem(args), max_xlen) << endl; } void sim_t::interactive_str(const std::string& cmd, const std::vector<std::string>& args) @@ -497,11 +516,13 @@ void sim_t::interactive_str(const std::string& cmd, const std::vector<std::strin reg_t addr = strtol(addr_str.c_str(),NULL,16); + ostream out(sout_.rdbuf()); + char ch; while((ch = mmu->load_uint8(addr++))) - sout << ch; + out << ch; - sout << endl; + out << endl; } void sim_t::interactive_until_silent(const std::string& cmd, const std::vector<std::string>& args) diff --git a/riscv/processor.cc b/riscv/processor.cc index 46f4ed3..0aa0d83 100644 --- a/riscv/processor.cc +++ b/riscv/processor.cc @@ -32,10 +32,10 @@ using std::endl; processor_t::processor_t(const char* isa, const char* priv, const char* varch, simif_t* sim, uint32_t id, bool halt_on_reset, - FILE* log_file, ostream *sout_ptr_ctor) + FILE* log_file, ostream& sout_) : debug(false), halt_request(HR_NONE), sim(sim), id(id), xlen(0), histogram_enabled(false), log_commits_enabled(false), - log_file(log_file), halt_on_reset(halt_on_reset), + log_file(log_file), sout_(sout_.rdbuf()), halt_on_reset(halt_on_reset), extension_table(256, false), impl_table(256, false), last_pc(1), executions(1) { VU.p = this; @@ -60,8 +60,6 @@ processor_t::processor_t(const char* isa, const char* priv, const char* varch, else if (max_xlen == 64) set_mmu_capability(IMPL_MMU_SV48); - sout_ptr = sout_ptr_ctor; // needed for command line option -s - reset(); } @@ -751,10 +749,12 @@ void processor_t::enter_debug_mode(uint8_t cause) void processor_t::debug_output_log(stringstream *s) { - if (log_file==stderr) - *sout_ptr << s->str(); // handles command line options -d -s -l - else + if (log_file==stderr) { + ostream out(sout_.rdbuf()); + out << s->str(); // handles command line options -d -s -l + } else { fputs(s->str().c_str(), log_file); // handles command line option --log + } } void processor_t::take_trap(trap_t& t, reg_t epc) diff --git a/riscv/processor.h b/riscv/processor.h index 450d650..1b11820 100644 --- a/riscv/processor.h +++ b/riscv/processor.h @@ -288,7 +288,7 @@ class processor_t : public abstract_device_t public: processor_t(const char* isa, const char* priv, const char* varch, simif_t* sim, uint32_t id, bool halt_on_reset, - FILE *log_file, ostream *sout_ptr); // because of command line option --log and -s we need both + FILE *log_file, std::ostream& sout_); // because of command line option --log and -s we need both ~processor_t(); void set_debug(bool value); @@ -478,7 +478,7 @@ private: bool histogram_enabled; bool log_commits_enabled; FILE *log_file; - ostream *sout_ptr; // needed for socket command interface -s, also used for -d and -l, but not for --log + std::ostream sout_; // needed for socket command interface -s, also used for -d and -l, but not for --log bool halt_on_reset; std::vector<bool> extension_table; std::vector<bool> impl_table; diff --git a/riscv/sim.cc b/riscv/sim.cc index 317d5b4..042d0f0 100644 --- a/riscv/sim.cc +++ b/riscv/sim.cc @@ -57,7 +57,7 @@ sim_t::sim_t(const char* isa, const char* priv, const char* varch, io_service_ptr(io_service_ptr), // socket interface acceptor_ptr(acceptor_ptr), #endif - sout(nullptr), + sout_(nullptr), current_step(0), current_proc(0), debug(false), @@ -68,7 +68,7 @@ sim_t::sim_t(const char* isa, const char* priv, const char* varch, { signal(SIGINT, &handle_signal); - sout.rdbuf(cerr.rdbuf()); // debug output goes to stderr by default + sout_.rdbuf(cerr.rdbuf()); // debug output goes to stderr by default for (auto& x : mems) bus.add_device(x.first, x.second); @@ -91,7 +91,7 @@ sim_t::sim_t(const char* isa, const char* priv, const char* varch, for (size_t i = 0; i < nprocs; i++) { int hart_id = hartids.empty() ? i : hartids[i]; procs[i] = new processor_t(isa, priv, varch, this, hart_id, halted, - log_file.get(), &sout); + log_file.get(), sout_); } make_dtb(); diff --git a/riscv/sim.h b/riscv/sim.h index cf50de5..714b766 100644 --- a/riscv/sim.h +++ b/riscv/sim.h @@ -111,7 +111,7 @@ private: string rin(streambuf *bout_ptr); // read input command string void wout(streambuf *bout_ptr); // write output to socket #endif - ostream sout; // used for socket and terminal interface + ostream sout_; // used for socket and terminal interface processor_t* get_core(const std::string& i); void step(size_t n); // step through simulation diff --git a/spike_main/spike-log-parser.cc b/spike_main/spike-log-parser.cc index 80a590b..9481fb4 100644 --- a/spike_main/spike-log-parser.cc +++ b/spike_main/spike-log-parser.cc @@ -27,7 +27,7 @@ int main(int argc, char** argv) parser.option(0, "isa", 1, [&](const char* s){isa = s;}); parser.parse(argv); - processor_t p(isa, DEFAULT_PRIV, DEFAULT_VARCH, 0, 0, false, nullptr, nullptr); + processor_t p(isa, DEFAULT_PRIV, DEFAULT_VARCH, 0, 0, false, nullptr, cerr); if (extension) { p.register_extension(extension()); } |