From 294aa666fe09a8b6ca133201c7593c54d3cab6e8 Mon Sep 17 00:00:00 2001 From: John Levon Date: Thu, 12 May 2022 15:20:51 +0100 Subject: build PR runs in release mode (#669) Instead of "plain", which doesn't specify any optimization, use "release", which both turns off -DDEBUG and enables -O3. Switch the default build to "debug" - we can't use optimization if we want to run valgrind, as there are apparent CPython bugs that trip up valgrind in that case. Signed-off-by: John Levon Reviewed-by: Swapnil Ingle --- .github/workflows/pull_request.sh | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to '.github') diff --git a/.github/workflows/pull_request.sh b/.github/workflows/pull_request.sh index 688ca0c..20b8ace 100755 --- a/.github/workflows/pull_request.sh +++ b/.github/workflows/pull_request.sh @@ -18,22 +18,22 @@ CC=clang meson build/clang-debug -Dtran-pipe=true ninja -C $BUILD/clang-debug -v meson test -C $BUILD/clang-debug --no-suite style --print-errorlogs -# plain build with clang -CC=clang meson build/clang-plain -Dtran-pipe=true -Dbuildtype=plain -ninja -C $BUILD/clang-plain -v -meson test -C $BUILD/clang-plain --no-suite style --print-errorlogs +# release build with clang +CC=clang meson build/clang-release -Dtran-pipe=true -Dbuildtype=release +ninja -C $BUILD/clang-release -v +meson test -C $BUILD/clang-release --no-suite style --print-errorlogs # debug build with gcc CC=gcc meson build/gcc-debug -Dtran-pipe=true ninja -C $BUILD/gcc-debug -v meson test -C $BUILD/gcc-debug --no-suite style --print-errorlogs -# plain build with gcc -CC=gcc meson build/gcc-plain -Dtran-pipe=true -Dbuildtype=plain -ninja -C $BUILD/gcc-plain -v -meson test -C $BUILD/gcc-plain --no-suite style --print-errorlogs +meson test -C $BUILD/gcc-debug --suite unit --setup valgrind --print-errorlogs +meson test -C $BUILD/gcc-debug --suite pyunit --setup pyvalgrind --print-errorlogs -meson test -C $BUILD/gcc-plain --suite unit --setup valgrind --print-errorlogs -meson test -C $BUILD/gcc-plain --suite pyunit --setup pyvalgrind --print-errorlogs +DESTDIR=tmp.install meson install -C $BUILD/gcc-debug -DESTDIR=tmp.install meson install -C $BUILD/gcc-plain +# release build with gcc +CC=gcc meson build/gcc-release -Dtran-pipe=true -Dbuildtype=release +ninja -C $BUILD/gcc-release -v +meson test -C $BUILD/gcc-release --no-suite style --print-errorlogs -- cgit v1.1