diff options
| author | John Levon <john.levon@nutanix.com> | 2023-01-03 12:23:43 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-03 12:23:43 +0000 |
| commit | 3eb7ff6579740a5b962c1a52804b0ec5b29a4c42 (patch) | |
| tree | f7a519153645a4560eae19e3e9843adafef3cd9c /lib/pci_caps.c | |
| parent | ad96efb02c27ec22116fb5800b48a6c9df27958f (diff) | |
| download | libvfio-user-3eb7ff6579740a5b962c1a52804b0ec5b29a4c42.zip libvfio-user-3eb7ff6579740a5b962c1a52804b0ec5b29a4c42.tar.gz libvfio-user-3eb7ff6579740a5b962c1a52804b0ec5b29a4c42.tar.bz2 | |
fix FLR reset callback (#729)
A reset callback is allowed to call functions disallowed in quiescent
state. However, the FLR reset path neglected to account for this
properly, causing an incorrect assert to be triggered if, for example,
vfu_sgl_put() is called. To fix this, make sure all reset paths go
through call_reset_cb().
Signed-off-by: John Levon <john.levon@nutanix.com>
Reviewed-by: Thanos Makatos <thanos.makatos@nutanix.com>
Diffstat (limited to 'lib/pci_caps.c')
| -rw-r--r-- | lib/pci_caps.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/pci_caps.c b/lib/pci_caps.c index 50eb29b..73e2645 100644 --- a/lib/pci_caps.c +++ b/lib/pci_caps.c @@ -270,7 +270,7 @@ handle_px_pxdc_write(vfu_ctx_t *vfu_ctx, struct pxcap *px, } if (vfu_ctx->reset != NULL) { vfu_log(vfu_ctx, LOG_DEBUG, "initiate function level reset"); - return vfu_ctx->reset(vfu_ctx, VFU_RESET_PCI_FLR); + return call_reset_cb(vfu_ctx, VFU_RESET_PCI_FLR); } else { vfu_log(vfu_ctx, LOG_ERR, "FLR callback is not implemented"); } |