re-work access handling (#220)

Various cleanups and fixes to handling of region accesses, including:

- there should be no reason for us to split accesses into 1/2/4/8 byte accesses:
in general, the client will have already be doing that, and if not, there's no
particular reason we should be the ones to split up such larger accesses.

- use a callback for PCI config space reads and writes if one is provided (needs
more work for capabilities)

Signed-off-by: John Levon <john.levon@nutanix.com>
Reviewed-by: Swapnil Ingle <swapnil.ingle@nutanix.com>
Reviewed-by: Thanos Makatos <thanos.makatos@nutanix.com>

1 files changed, 0 insertions, 11 deletions

diff --git a/lib/pci.h b/lib/pci.h
index 8678902..b38b12b 100644
--- a/lib/pci.h
+++ b/lib/pci.h
@@ -36,17 +36,6 @@
 #include "libvfio-user.h"
 #include "private.h"
 
-static inline bool
-pci_is_hdr_access(uint64_t pos)
-{
-    const uint64_t off = region_to_offset(VFU_PCI_DEV_CFG_REGION_IDX);
-    return pos >= off && pos - off < PCI_STD_HEADER_SIZEOF;
-}
-
-int
-pci_hdr_access(vfu_ctx_t *vfu_ctx, uint32_t *count,
-               uint64_t *pos, bool is_write, char *buf);
-
 ssize_t
 pci_config_space_access(vfu_ctx_t *vfu_ctx, char *buf, size_t count,
                         loff_t pos, bool is_write);