aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Levon <john.levon@nutanix.com>2021-05-20 11:47:52 +0100
committerGitHub <noreply@github.com>2021-05-20 11:47:52 +0100
commit04388b3757d24dc7c368cc8f30832adfbc1c444f (patch)
tree93fd3b3ff98e8466f0deae04d5cdd00859cb218d
parent3b1f4e00a610dcdba22ac8e86d019944229522a6 (diff)
downloadlibvfio-user-04388b3757d24dc7c368cc8f30832adfbc1c444f.zip
libvfio-user-04388b3757d24dc7c368cc8f30832adfbc1c444f.tar.gz
libvfio-user-04388b3757d24dc7c368cc8f30832adfbc1c444f.tar.bz2
validate_irq_subindex: skip check of vfu_ctx pointer (#499)
Signed-off-by: John Levon <john.levon@nutanix.com> Reviewed-by: Swapnil Ingle <swapnil.ingle@nutanix.com>
-rw-r--r--lib/irq.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/irq.c b/lib/irq.c
index fde17dc..6a73a30 100644
--- a/lib/irq.c
+++ b/lib/irq.c
@@ -378,10 +378,6 @@ handle_device_set_irqs(vfu_ctx_t *vfu_ctx, vfu_msg_t *msg)
static bool
validate_irq_subindex(vfu_ctx_t *vfu_ctx, uint32_t subindex)
{
- if (vfu_ctx == NULL) {
- return false;
- }
-
if ((subindex >= vfu_ctx->irqs->max_ivs)) {
vfu_log(vfu_ctx, LOG_ERR, "bad IRQ %d, max=%d", subindex,
vfu_ctx->irqs->max_ivs);
@@ -396,6 +392,8 @@ vfu_irq_trigger(vfu_ctx_t *vfu_ctx, uint32_t subindex)
{
eventfd_t val = 1;
+ assert(vfu_ctx != NULL);
+
if (!validate_irq_subindex(vfu_ctx, subindex)) {
return ERROR_INT(EINVAL);
}