aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Weil <sw@weilnetz.de>2012-09-04 23:20:36 +0200
committerJan Kiszka <jan.kiszka@siemens.com>2012-09-13 12:38:14 +0200
commit68a9cbb2bbcb8687f0e3d6f4847b01925dffdd17 (patch)
tree1d6f2d1f6265bdcefcf59ece2a2518944a18c5c8
parent9f12aed390fefdc61e6224d5cd56b111ea4e22e2 (diff)
downloadslirp-68a9cbb2bbcb8687f0e3d6f4847b01925dffdd17.zip
slirp-68a9cbb2bbcb8687f0e3d6f4847b01925dffdd17.tar.gz
slirp-68a9cbb2bbcb8687f0e3d6f4847b01925dffdd17.tar.bz2
slirp: Fix error reported by static code analysis
Report from smatch: slirp/tcp_subr.c:127 tcp_respond(17) error: we previously assumed 'tp' could be null (see line 124) Return if 'tp' is NULL. Signed-off-by: Stefan Weil <sw@weilnetz.de> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
-rw-r--r--tcp_subr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tcp_subr.c b/tcp_subr.c
index ae319d9..d55259e 100644
--- a/tcp_subr.c
+++ b/tcp_subr.c
@@ -121,7 +121,7 @@ void tcp_respond(struct tcpcb *tp, struct tcpiphdr *ti, struct mbuf *m,
if (tp)
win = sbspace(&tp->t_socket->so_rcv);
if (m == NULL) {
- if ((m = m_get(tp->t_socket->slirp)) == NULL)
+ if (!tp || (m = m_get(tp->t_socket->slirp)) == NULL)
return;
tlen = 0;
m->m_data += IF_MAXLINKHDR;