From 99aca9efe10c005189b47160d178d18f14301c7e Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Mon, 28 Feb 2022 12:08:22 -0700 Subject: abuf: Correct a corner case with abuf_realloc() If the buffer is empty and not allocated, then abuf_realloc() tries to copy invalid data. This happens because an incorrect change to use memdup() was added after the original code was written. Signed-off-by: Simon Glass --- lib/abuf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'lib/abuf.c') diff --git a/lib/abuf.c b/lib/abuf.c index 4b17e0b..1635d58 100644 --- a/lib/abuf.c +++ b/lib/abuf.c @@ -51,9 +51,11 @@ bool abuf_realloc(struct abuf *abuf, size_t new_size) /* not currently allocated and new size is larger. Alloc and * copy in data. The new space is not inited. */ - ptr = memdup(abuf->data, new_size); + ptr = malloc(new_size); if (!ptr) return false; + if (abuf->size) + memcpy(ptr, abuf->data, abuf->size); abuf->data = ptr; abuf->size = new_size; abuf->alloced = true; -- cgit v1.1