From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- include/tsec.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'include/tsec.h') diff --git a/include/tsec.h b/include/tsec.h index b17fa95..43255e5 100644 --- a/include/tsec.h +++ b/include/tsec.h @@ -426,8 +426,9 @@ struct tsec_info_struct { }; #ifndef CONFIG_DM_ETH -int tsec_standard_init(bd_t *bis); -int tsec_eth_init(bd_t *bis, struct tsec_info_struct *tsec_info, int num); +int tsec_standard_init(struct bd_info *bis); +int tsec_eth_init(struct bd_info *bis, struct tsec_info_struct *tsec_info, + int num); #endif #endif /* __TSEC_H */ -- cgit v1.1