From 68c0912bf25d71e48f0775051b58443ad35faf23 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sat, 26 Oct 2019 23:45:08 +0200 Subject: hush: re-sequence includes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 'make tests' on a 32bit ARM system leads to In file included from ../common/cli_hush.c:79: ../include/malloc.h:364:7: error: conflicting types for ‘memset’ void* memset(void*, int, size_t); ^~~~~~ In file included from ../include/compiler.h:126, from ../include/env.h:12, from ../common/cli_hush.c:78: ../include/linux/string.h:103:15: note: previous declaration of ‘memset’ was here extern void * memset(void *,int,__kernel_size_t); ^~~~~~ In file included from ../common/cli_hush.c:79: ../include/malloc.h:365:7: error: conflicting types for ‘memcpy’ void* memcpy(void*, const void*, size_t); ^~~~~~ In file included from ../include/compiler.h:126, from ../include/env.h:12, from ../common/cli_hush.c:78: ../include/linux/string.h:106:15: note: previous declaration of ‘memcpy’ was here extern void * memcpy(void *,const void *,__kernel_size_t); ^~~~~~ According to the U-Boot coding style guide common.h should be the first include. Signed-off-by: Heinrich Schuchardt --- common/cli_hush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'common/cli_hush.c') diff --git a/common/cli_hush.c b/common/cli_hush.c index 8f86e4a..cf1e273 100644 --- a/common/cli_hush.c +++ b/common/cli_hush.c @@ -75,10 +75,10 @@ #define __U_BOOT__ #ifdef __U_BOOT__ +#include /* readline */ #include #include /* malloc, free, realloc*/ #include /* isalpha, isdigit */ -#include /* readline */ #include #include #include -- cgit v1.1