From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- board/freescale/t208xqds/t208xqds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'board/freescale/t208xqds/t208xqds.h') diff --git a/board/freescale/t208xqds/t208xqds.h b/board/freescale/t208xqds/t208xqds.h index 68c758f..50ebb6f 100644 --- a/board/freescale/t208xqds/t208xqds.h +++ b/board/freescale/t208xqds/t208xqds.h @@ -7,6 +7,6 @@ #define __CORENET_DS_H__ void fdt_fixup_board_enet(void *blob); -void pci_of_setup(void *blob, bd_t *bd); +void pci_of_setup(void *blob, struct bd_info *bd); #endif -- cgit v1.1