From 69d5f497d3b63db0e5897456ebb57b03ea731aac Mon Sep 17 00:00:00 2001 From: Tom Rini Date: Tue, 10 Jan 2023 11:19:46 -0500 Subject: CI: Make check for new defined CONFIG symbols even more robust Now that all remaining in-tree cases where we define or undef a CONFIG symbol have been migrated to Kconfig or renamed to CFG we can make the CI check more robust. We will exclude the doc, tools and arch/arm/dts directories from this check as they are special cases. Further, we can exclude the scripts/kconfig/lkc.h and include/linux/kconfig.h files as the CONFIG values they define are special tooling cases and not real symbols. In the case of docs, the only places that currently fail this test are old documentation that should be rewritten so that we can remove this special case. Signed-off-by: Tom Rini Reviewed-by: Simon Glass --- .azure-pipelines.yml | 3 ++- .gitlab-ci.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml index 49fc34f..5673bb7 100644 --- a/.azure-pipelines.yml +++ b/.azure-pipelines.yml @@ -64,7 +64,8 @@ stages: # If grep succeeds and finds a match the test fails as we should # have no matches. - script: git grep -E '^#[[:blank:]]*(define|undef)[[:blank:]]*CONFIG_' - include/configs `find arch -name config.h` && exit 1 || exit 0 + :^doc/ :^arch/arm/dts/ :^scripts/kconfig/lkc.h + :^include/linux/kconfig.h :^tools/ && exit 1 || exit 0 - job: cppcheck displayName: 'Static code analysis with cppcheck' diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 398fa2b..aaf9d25 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -131,7 +131,8 @@ check for new CONFIG symbols outside Kconfig: # If grep succeeds and finds a match the test fails as we should # have no matches. - git grep -E '^#[[:blank:]]*(define|undef)[[:blank:]]*CONFIG_' - include/configs `find arch -name config.h` && exit 1 || exit 0 + :^doc/ :^arch/arm/dts/ :^scripts/kconfig/lkc.h + :^include/linux/kconfig.h :^tools/ && exit 1 || exit 0 # QA jobs for code analytics # static code analysis with cppcheck (we can add --enable=all later) -- cgit v1.1