From 063359444c251163cf0e4159355bc545b486d01d Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sat, 1 Apr 2023 09:06:55 +0200 Subject: usb: gadget: missing fallthrough in composite_setup() Add a missing fallthrough macro. This fixes a -Wimplicit-fallthrough warning. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/composite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 2a309e6..04b8541 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -1068,7 +1068,7 @@ composite_setup(struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl) if (!gadget_is_dualspeed(gadget) || gadget->speed >= USB_SPEED_SUPER) break; - + fallthrough; case USB_DT_CONFIG: value = config_desc(cdev, w_value); if (value >= 0) -- cgit v1.1 From 7f2347088529693ee13b4ab7e7a27f5a1f617c1f Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Tue, 7 Mar 2023 08:42:33 +0100 Subject: usb: gadget: f_sdp: Add missing spl_board_prepare_for_boot() call The spl_board_prepare_for_boot() should be called before jump_to_image_no_args() to perform board-specific deinitialization before jumping to the next stage. This board-specific deinitialization can be very much anything, e.g. disable dcache in case it was enabled, or such. Add the missing spl_board_prepare_for_boot() call into f_sdp . Signed-off-by: Marek Vasut --- drivers/usb/gadget/f_sdp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c index 9ea43f2..4da5a16 100644 --- a/drivers/usb/gadget/f_sdp.c +++ b/drivers/usb/gadget/f_sdp.c @@ -865,6 +865,7 @@ static int sdp_handle_in_ep(struct spl_image_info *spl_image, struct spl_image_info spl_image = {}; struct spl_boot_device bootdev = {}; spl_parse_image_header(&spl_image, &bootdev, header); + spl_board_prepare_for_boot(); jump_to_image_no_args(&spl_image); #else /* In U-Boot, allow jumps to scripts */ -- cgit v1.1