aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-02-19Merge tag 'u-boot-imx-master-20240219' of ↵WIP/19Feb2024Tom Rini24-19/+1323
https://gitlab.denx.de/u-boot/custodians/u-boot-imx CI: https://source.denx.de/u-boot/custodians/u-boot-imx/-/pipelines/19683 - Convert msc_sm2s_imx8mp to DM_SERIAL. - Make Ethernel functional on msc_sm2s_imx8mp. - General improvements for msc_sm2s_imx8mp. - Add suport for the Sielaff i.MX6 Solo board. - Update GE HealthCare maitainers' e-mail addresses.
2024-02-19doc: board: Add minimal documentation for Sielaff i.MX6 Solo boardFrieder Schrempf3-0/+39
Describe how to build and boot for the Sielaff i.MX6 Solo board. Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
2024-02-19board: Add support for Sielaff i.MX6 Solo boardFrieder Schrempf12-0/+1257
The Sielaff i.MX6 Solo board is a control and HMI board for vending machines. Add support for this board. The devicetree files are taken from pending changes in the Linux kernel that are available from linux-next and will likely be part of Linux v6.9. Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
2024-02-19mtd: spi-nor-ids: Add support for ESMT/EON EN25Q80BFrieder Schrempf1-0/+1
The datasheet can be found here: https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25Q80B_Ver.E.pdf Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> Reviewed-by: Fabio Estevam <festevam@gmail.com>
2024-02-19MAINTAINERS: Update after GEHC spin-offIan Ray4-6/+5
Update our email addresses, from @ge.com to @gehealthcare.com, after GE HealthCare was spun-off from GE. Remove Antti, who no longer works on the project. Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
2024-02-19msc_sm2s_imx8mp: Fix CONFIG_DEFAULT_FDT_FILEFabio Estevam1-1/+1
There is no imx8mp-msc-sm2s.dtb file in upstream Linux. Change it to imx8mp-msc-sm2s-ep1.dtb. Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Ian Ray <ian.ray@gehealthcare.com>
2024-02-19msc_sm2s_imx8mp: Add redundant environment supportFabio Estevam1-1/+5
Redundant environment support is required for software updates. Add support for it. Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Ian Ray <ian.ray@gehealthcare.com>
2024-02-19imx8mp-msc-sm2s: Add mmc aliasesFabio Estevam1-0/+5
Add mmc alias so that the eMMC is mmc0 and the SD card is mmc1 to have a well defined device numbering scheme. Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Ian Ray <ian.ray@gehealthcare.com>
2024-02-19msc_sm2s_imx8mp: Make Ethernet functionalFabio Estevam1-0/+1
Currently, the Ethernet ports are not working. The Ethernet PHY reset lines are controlled by the TCA6424 I2C GPIO expander. The TCA6424 I2C GPIO expander is supported by the CONFIG_DM_PCA953X driver. Select the CONFIG_DM_PCA953X option so that the Ethernet PHYs can go through a proper reset making Ethernet to be functional. Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Ian Ray <ian.ray@gehealthcare.com>
2024-02-19msc_sm2s_imx8mp: Convert to DM_SERIALFabio Estevam4-11/+9
The conversion to DM_SERIAL is mandatory, so do the conversion. Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Ian Ray <ian.ray@gehealthcare.com>
2024-02-17Merge branch 'master-porter' of ↵WIP/17Feb2024Tom Rini11-1/+28
https://source.denx.de/u-boot/custodians/u-boot-sh - Renesas R-Car Gen2 fixes
2024-02-17ARM: renesas: Enable LTO on R-CarMarek Vasut1-0/+1
Enable LTO globally on Renesas R-Car platforms. This has been enabled on a subset of boards already, but at this point it is safe to enable it globally. This saves units or tens of kiB from the resulting build. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Reviewed-by: Paul Barker <paul.barker.ct@bp.renesas.com>
2024-02-17ARM: renesas: Set R-Car Gen2 board size limit to 512 kiBMarek Vasut1-1/+2
The maximum size of u-boot.img on R-Car Gen2 is 0x80000 or 512 kiB, set the limit to avoid overflows as new functionality gets pulled in. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Reviewed-by: Paul Barker <paul.barker.ct@bp.renesas.com>
2024-02-17ARM: renesas: Disable EFI on R-Car Gen2Marek Vasut8-0/+16
These systems are unlikely to use EFI as this functionality has not been enabled until it got pulled in by Kconfig default. This functionality does add some 60-70 kiB to the u-boot.img size, which overflows the size limit. Disable it. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Reviewed-by: Paul Barker <paul.barker.ct@bp.renesas.com>
2024-02-17clk: renesas: Fix broken clocks on all Gen2 boardsNiklas Söderlund1-0/+9
To prepare support for multiple register layouts pointers to register tables where added to struct cpg_mssr_info. These pointers are suppose to be filled in at probe time and no intended change in behavior was intended. However the new pointers where only filled in by some paths of the driver implemented in clk-rcar-gen3.c. The path implemented in clk-rcar-gen2.c was not updated leaving the pointers uninitialized leading to a crash when trying to probe the clocks. Fix this by filling in the pointers in the Gen2 code path with the values used before they where moved to struct cpg_mssr_info. Fixes: d413214fb748 ("clk: renesas: Add register pointers into struct cpg_mssr_info") Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Acked-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Tested-by: Marek Vasut <marek.vasut+renesas@mailbox.org> # R8A7791 Porter Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
2024-02-15Merge tag 'u-boot-dfu-20240215' of ↵WIP/15Feb2024Tom Rini6-110/+180
https://source.denx.de/u-boot/custodians/u-boot-dfu u-boot-dfu-20240215 - Fix avb_verify command with SD cards - Add u-boot-dfu maintainer tree for AB/AVB - Avb: report verified boot state based on lock state - Misc avb refactors improve code quality
2024-02-15doc: android: avb: sync usage detailsIgor Opaniuk1-5/+11
Sync usage info with the one cmd/avb.c. Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Link: https://lore.kernel.org/r/20240209192045.3961832-8-igor.opaniuk@foundries.io Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
2024-02-15cmd: avb: rework do_avb_verify_partIgor Opaniuk1-33/+17
Use existing str_avb_slot_error() function for obtaining verification fail reason details. Take into account device lock state for setting correct androidboot.verifiedbootstate kernel cmdline parameter. Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com> Link: https://lore.kernel.org/r/20240209192045.3961832-7-igor.opaniuk@foundries.io Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
2024-02-15common: avb_verify: add str_avb_io_error/str_avb_slot_errorIgor Opaniuk2-1/+51
Introduce str_avb_io_error() and str_avb_slot_error() functions, that provide a pointer to AVB runtime error message. Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com> Link: https://lore.kernel.org/r/20240209192045.3961832-6-igor.opaniuk@foundries.io Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
2024-02-15cmd: avb: rework printsIgor Opaniuk1-48/+75
Simplify and add more context for prints where it's needed. Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Link: https://lore.kernel.org/r/20240209192045.3961832-5-igor.opaniuk@foundries.io Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
2024-02-15common: avb_verify: rework error/debug printsIgor Opaniuk1-13/+18
Make error prints more verbose with additional context. Also s/print/debug/g for prints, which might be relevant only for debugging purposes. Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com> Link: https://lore.kernel.org/r/20240209192045.3961832-4-igor.opaniuk@foundries.io Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
2024-02-15avb: move SPDX license identifiers to the first lineIgor Opaniuk4-10/+4
Move SPDX license identifiers to the first line, so it conforms to license placement rule [1]: Placement: The SPDX license identifier in kernel files shall be added at the first possible line in a file which can contain a comment. For the majority of files this is the first line, except for scripts which require the '#!PATH_TO_INTERPRETER' in the first line. For those scripts the SPDX identifier goes into the second line. [1] https://www.kernel.org/doc/Documentation/process/license-rules.rst Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com> Link: https://lore.kernel.org/r/20240209192045.3961832-3-igor.opaniuk@foundries.io Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
2024-02-15common: avb_verify: don't call mmc_switch_part for SDIgor Opaniuk1-3/+5
mmc_switch_part() is used for switching between hw partitions on eMMC (boot0, boot1, user, rpmb). There is no need to do that for SD card. This fixes the avb command usage on SD cards. Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com> Reviewed-by: Dragan Simic <dsimic@manjaro.org> Link: https://lore.kernel.org/r/20240209192045.3961832-2-igor.opaniuk@foundries.io Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
2024-02-15MAINTAINERS: add custodian tree info for AVB/ABIgor Opaniuk1-0/+2
Add information about a custodian tree [1] for AVB/AB, which is maintained by Mattijs Korpershoek. [1] https://source.denx.de/u-boot/custodians/u-boot-dfu Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Reviewed-by: Marek Vasut <marex@denx.de> Link: https://lore.kernel.org/r/20240213073638.1125429-1-igor.opaniuk@foundries.io Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
2024-02-14Merge tag 'xilinx-for-v2024.04-rc3' of ↵WIP/14Feb2024Tom Rini17-79/+149
https://source.denx.de/u-boot/custodians/u-boot-microblaze Xilinx changes for v2024.04-rc3 zynqmp: - Cover missing _SE chip variants to fix fpga programming versal: - Enable LTO for mini configurations versal-net: - Enable LTO for mini configurations - Fix GIC address to aligned with real silicon xilinx: - DTs cleanup and fixups - Enable HTTP boot - Add missing spl header to zynqmp.c
2024-02-14arm64: versal-net: Setup correct addresses of GICR/GICDMichal Simek1-2/+2
Previous addresses where used in past in emulation environment but never gets to silicon that's why use correct addresses. Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/5d3d0e1afb1f673ffeb4a1c5d7f040475c806a30.1707220293.git.michal.simek@amd.com
2024-02-13Prepare v2024.04-rc2v2024.04-rc2Tom Rini2-2/+2
Signed-off-by: Tom Rini <trini@konsulko.com>
2024-02-13Merge branch '2024-02-13-assorted-updates'Tom Rini10-56/+132
- Add the button command patch, update MAINTAINERS entry for a platform, fix a problem with the hash command, fix a problem on K3 platforms and revert a change on verdin-am62.
2024-02-13Revert "board: verdin-am62: set cpu core voltage depending on speed grade"WIP/2024-02-13-assorted-updatesFrancesco Dolcini1-47/+0
This reverts commit d2099587d661c6ca2309256c0e04c06e26c8d34c. According to TI changing the VDD_CORE while the SoC is running is not allowed, the voltage must be set before the AM62 device reset is released, revert this change therefore. The correct solution would be to program the PMIC during manufactoring according to the speed grade of the SoC. Link: https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1318338/am623-booting-from-mmc-failed-after-lowering-vdd_core-to-0-75v/5036508#5036508 Fixes: d2099587d661 ("board: verdin-am62: set cpu core voltage depending on speed grade") Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
2024-02-13boot: add support for button commandsCaleb Connolly6-0/+115
With the relatively new button API in U-Boot, it's now much easier to model the common usecase of mapping arbitrary actions to different buttons during boot - for example entering fastboot mode, setting some additional kernel cmdline arguments, or booting with a custom recovery ramdisk, to name a few. Historically, this functionality has been implemented in board code, making it fixed for a given U-Boot binary and requiring the code be duplicated and modified for every board. Implement a generic abstraction to run an arbitrary command during boot when a specific button is pressed. The button -> command mapping is configured via environment variables with the following format: button_cmd_N_name=<button label> button_cmd_N=<command to run> Where N is the mapping number starting from 0. For example: button_cmd_0_name=vol_down button_cmd_0=fastboot usb 0 This will cause the device to enter fastboot mode if volume down is held during boot. After we enter the cli loop the button commands are no longer valid, this allows the buttons to additionally be used for navigating a boot menu. Tested-by: Svyatoslav Ryhel <clamor95@gmail.com> # Tegra30 Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
2024-02-13cmd: hash: fix param count checkIgor Opaniuk1-9/+10
Add correct check for parameter count. This fixes this issue when `hash` cmd is invoked without params: => hash data abort pc : [<bf739204>] lr : [<ba6effa8>] reloc pc : [<60019204>] lr : [<5afcffa8>] sp : ba6dd9c8 ip : bf7391f0 fp : bf74ec14 r10: 00000001 r9 : ba6dfea0 r8 : bf7ea030 r7 : 00000000 r6 : ba6effa8 r5 : 00000000 r4 : ffffffff r3 : bf7c257c r2 : 00000001 r1 : 00000000 r0 : bf7e6e34 Flags: nZCv IRQs off FIQs on Mode SVC_32 Code: e5934004 e1a0e003 e59f3050 e2444001 (e5f4c001) Resetting CPU ... resetting ... Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>
2024-02-13memory: ti-gpmc: Fix lock up at A53 SPL during NAND boot on AM64-EVMRoger Quadros1-0/+6
AM64 ES2.0 bootrom seems to enable WAIT0EDGEDETECTION interrupt. This causes a lockup at A53 SPL when accessing NAND controller or ELM registers. A good option would be to softrest GPMC block at probe but this cannot be done for AM64 as SOFTRESET bit is marked as reserved in SYSCONFIG register. Fix the issue by disabling all IRQs at probe. Signed-off-by: Roger Quadros <rogerq@kernel.org>
2024-02-13poplar: add myself as co-maintainerIgor Opaniuk1-0/+1
Add myself as co-maintainer for Poplar board, as I'm currently working on it (re-testing releases, addressing issues etc). CC: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com> CC: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Igor Opaniuk <igor.opaniuk@foundries.io> Acked-by: Shawn Guo <shawn.guo@linaro.org> Acked-by: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com>
2024-02-12Merge tag 'doc-2024-04-rc2' of ↵Tom Rini6-20/+81
https://source.denx.de/u-boot/custodians/u-boot-efi Pull request doc-2024-04-rc2 Documentation: * Fix and extend utf8_to_utf32_stream() documentation * Fix rendering of OpenSBI logo in VisionFive 2 description * Document imxrt1170-evk board * codingstyle.rst: Clarify include section UEFI: * simplify error message in efi_disk_create_raw()
2024-02-12net: designware: Support high memory nodesNils Le Roux1-7/+9
Some platforms (such as the Lichee Pi 4A) have their dwmac device addressable only in high memory space. Storing the node's base address on 32 bits is not possible in such case. Use platform's physical address type to store the base address. Signed-off-by: Nils Le Roux <gilbsgilbert@gmail.com> Cc: Andre Przywara <andre.przywara@arm.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
2024-02-12doc/develop/codingstyle.rst: Clarify include sectionTom Rini1-12/+11
Rework the section about includes slightly. We should not be using common.h anywhere, so remove that from examples and ask people to send patches removing it when found. Doing this also means we need to reword other parts of this section. Be clearer about using alphabetical ordering. Signed-off-by: Tom Rini <trini@konsulko.com> Reviewed-by: Igor Opaniuk <igor.opaniuk@gmail.com>
2024-02-12lib: charset: Fix and extend utf8_to_utf32_stream() documentationJanne Grunau1-2/+12
Clarify usage of buffer argument. Signed-off-by: Janne Grunau <j@jannau.net> Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
2024-02-12efi_loader: simplify error message in efi_disk_create_raw()Heinrich Schuchardt1-1/+2
The error message Adding disk for usb_mass_storage.lun0 failed (err=-9223372036854775788/0x8000000000000014) provides a decimal and a hexadecimal notation of the EFI status code EFI_ALREADY_STARTED which is defined as (EFI_ERROR_MASK | 20). The decimal output does not convey the value 20 clearly. With the patch we write Adding block device usb_mass_storage.lun0 failed, r = 20 similar to other EFI error messages. Fixes: 952018117ab4 ("dm: sandbox: Switch over to using the new host uclass") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
2024-02-12doc: board: starfive: fix rendering of OpenSBI logoHeinrich Schuchardt1-5/+5
The rendering of the OpenSBI logo should look like the screen output. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
2024-02-12doc: imx: imxrt1170: Document imxrt1170-evk boardJesse Taube2-0/+51
Add documentation for imxrt1170-evk. Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Add index page entry, adjust formatting. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
2024-02-12Merge tag 'u-boot-imx-master-20240212' of ↵Tom Rini7-4/+23
https://gitlab.denx.de/u-boot/custodians/u-boot-imx CI: https://source.denx.de/u-boot/custodians/u-boot-imx/-/pipelines/19583 - Fix the i.MX8MP SPI compatible string. - Let the SPL clock code do the configuration on Data Modul i.MX8M Plus eDM SBC. - Enable secure boot on the imx93_var_som board.
2024-02-12xilinx: zynqmp: Add the missing function prototypeVenkatesh Yadav Abbarapu1-0/+1
Add missing prototype to fix the below sparse warning warning: no previous prototype for 'spl_spi_get_uboot_offs' [-Wmissing-prototypes] Fixes: 2c8a09219cdb ("arm64: zynqmp: Add multiboot support for SPL/SPI offset calculation") Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com> Link: https://lore.kernel.org/r/20240207083328.1673752-1-venkatesh.abbarapu@amd.com Signed-off-by: Michal Simek <michal.simek@amd.com>
2024-02-12arm64: zynqmp: Disable DP on kd240Michal Simek1-0/+4
When SOM dt is combined with kd240 overlay DPSUB is enabled but kd240 has no DP wired that's why change disable it via status property. Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/f6de217b3350c9d59032ef54800882e48f240398.1706791116.git.michal.simek@amd.com
2024-02-12arm64: zynqmp: Do not expose usbhub nodes on kr260 usb1Michal Simek2-1/+4
usb0 is already updated but forget to also update usb1. Fixes: 4ff083f09bc2 ("arm64: zynqmp: Do not expose usbhub nodes") Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/862ca748670f18f25d88aa5b43c37e3dd6aa35eb.1706791116.git.michal.simek@amd.com
2024-02-12arm64: zynqmp: Align nvmem-fw node with dt-schemaMichal Simek1-61/+64
Node name has to be renamed to be aligned with dt-schema and also xlnx,zynqmp-nvmem-fw switched to fixed-layout. Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/32899b20c1e282aab16c32074b1c9a3f45f6dac8.1706791116.git.michal.simek@amd.com
2024-02-12arm64: zynqmp: Remove arm,cortex-a53-edac nodeMichal Simek1-4/+0
There is no dt schema associated with it. Also Linux driver have been removed in Xilinx Linux tree and never gets to upstream that's why remove description for it. Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/6685ee980d9b475f95eef6b2a74795adc4ac4619.1706791116.git.michal.simek@amd.com
2024-02-12xilinx: Fix fpga region DT nodes nameMichal Simek2-2/+2
fpga-full is not aligned with the latest dt-schema. Generic name fpga-region should be used. Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/78e6e3f287f79917eb92c6c74accbaf955526aad.1706791116.git.michal.simek@amd.com
2024-02-12arm64: zynqmp: Fix kr260 clock wiringMichal Simek2-4/+16
kr260 revA/revA01 is using discrete oscilator for DP (27MHz) and si5332 for other clocks but clocks are different compare to kv260 that's why fix it to aligned with the latest schematics. On the other handle kr260 revB/revA03 also contains 74.25 MHz discrete clock chip for SLVC-EC output which is not defined. Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/e87ae94979c6efc909740bb1a569505042e4f876.1706626255.git.michal.simek@amd.com
2024-02-12arm64: zynqmp: Describe 25MHz fixed clock for PL GEMsMichal Simek1-0/+12
Describe 25Mhz fixed oscilator which is providing clock for PL based ethernet IPs. Physicially it is one chip but it is described as 2 fixed clock to be aligned with other SOM versions which were using integrated clock generators where clocks could be adjusted via i2c (si5332 chips). Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/c430aeacaa76d9f61ed3f874f721a33049f45eb9.1706514396.git.michal.simek@amd.com
2024-02-12arm64: zynqmp: Sync clock labels with kr260 revBMichal Simek1-7/+7
Board description describes the hard part of chip (PS) but programmable logic (PL) part is not described in this file. But clocks on the board are not only connected to PS but also wired to PL. And because two revisions are available where revA is using one si5332 and revB multiple clock chips using the same clock labels helping with keeping only one device tree overlay which targets PL. That's why synchronize clock labels and use labels from revB which are more generic. Unfortunately if there is driver for si5332 chip split could happen again but it is still worth to do it now and solve this issue when occurs. Reported-by: Sagar Karmarkar <sagar.karmarkar@amd.com> Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/abac6069e6029ed4076ec7b9d6b33604b6072aa3.1706253871.git.michal.simek@amd.com