aboutsummaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorSamuel Holland <samuel@sholland.org>2020-10-21 21:12:09 -0500
committerJagan Teki <jagan@amarulasolutions.com>2020-10-22 11:43:43 +0530
commitb26536ad3d940d64a070d7c2d0ecb0f28bad8289 (patch)
tree2e0135574772b2ae837f374075abe78ec548b43c /tools
parent509978e5d2cdfc2faff1721de035c1f4f14fbcae (diff)
downloadu-boot-b26536ad3d940d64a070d7c2d0ecb0f28bad8289.zip
u-boot-b26536ad3d940d64a070d7c2d0ecb0f28bad8289.tar.gz
u-boot-b26536ad3d940d64a070d7c2d0ecb0f28bad8289.tar.bz2
binman: Only write FDT once per node
Due to an extra level of indentation, the "data" property containing the FDT was being written repeatedly after every other property in the node. This caused the generated FIT image to be invalid. Move the block up one level, so the property is added exactly once. Reviewed-by: Simon Glass <sjg@chromium.org> Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/binman/etype/fit.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py
index de4745c..8a24f12 100644
--- a/tools/binman/etype/fit.py
+++ b/tools/binman/etype/fit.py
@@ -205,10 +205,10 @@ class Entry_fit(Entry):
b'SEQ', tools.ToBytes(str(seq + 1)))
fsw.property(pname, val)
- # Add data for 'fdt' nodes (but not 'config')
- if depth == 1 and in_images:
- fsw.property('data',
- tools.ReadFile(fname))
+ # Add data for 'fdt' nodes (but not 'config')
+ if depth == 1 and in_images:
+ fsw.property('data',
+ tools.ReadFile(fname))
else:
if self._fdts is None:
if self._fit_list_prop: