diff options
| author | Tom Rini <trini@konsulko.com> | 2018-07-06 10:27:14 -0600 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2018-07-09 09:11:00 -0600 |
| commit | 16d836cd6fa0d22e24fa2340df08e6d6d80c5107 (patch) | |
| tree | a6cb369eade526c6ae9d3c8286721d5452b3a929 /tools | |
| parent | 31e60ffa05b0952be3df8f584155567afdee50bd (diff) | |
| download | u-boot-16d836cd6fa0d22e24fa2340df08e6d6d80c5107.zip u-boot-16d836cd6fa0d22e24fa2340df08e6d6d80c5107.tar.gz u-boot-16d836cd6fa0d22e24fa2340df08e6d6d80c5107.tar.bz2 | |
binman: Switch to 'python-coverage'
The most portable way to get access to coverage is to invoke it as
'python-coverage'.
Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/binman/README | 3 | ||||
| -rwxr-xr-x | tools/binman/binman.py | 9 |
2 files changed, 6 insertions, 6 deletions
diff --git a/tools/binman/README b/tools/binman/README index 22f21bc..f74e392 100644 --- a/tools/binman/README +++ b/tools/binman/README @@ -583,8 +583,7 @@ implementations target 100% test coverage. Run 'binman -T' to check this. To enable Python test coverage on Debian-type distributions (e.g. Ubuntu): - $ sudo apt-get install python-pip python-pytest - $ sudo pip install coverage + $ sudo apt-get install python-coverage python-pytest Advanced Features / Technical docs diff --git a/tools/binman/binman.py b/tools/binman/binman.py index 31b0453..944fd5d 100755 --- a/tools/binman/binman.py +++ b/tools/binman/binman.py @@ -81,24 +81,25 @@ def RunTests(debug, args): def RunTestCoverage(): """Run the tests and check that we get 100% coverage""" # This uses the build output from sandbox_spl to get _libfdt.so - cmd = ('PYTHONPATH=$PYTHONPATH:%s/sandbox_spl/tools coverage run ' + cmd = ('PYTHONPATH=$PYTHONPATH:%s/sandbox_spl/tools python-coverage run ' '--include "tools/binman/*.py" --omit "*test*,*binman.py" ' 'tools/binman/binman.py -t' % options.build_dir) os.system(cmd) - stdout = command.Output('coverage', 'report') + stdout = command.Output('python-coverage', 'report') lines = stdout.splitlines() test_set= set([os.path.basename(line.split()[0]) for line in lines if '/etype/' in line]) glob_list = glob.glob(os.path.join(our_path, 'etype/*.py')) - all_set = set([os.path.basename(item) for item in glob_list]) + all_set = set([os.path.splitext(os.path.basename(item))[0] + for item in glob_list if '_testing' not in item]) missing_list = all_set missing_list.difference_update(test_set) - missing_list.remove('_testing.py') coverage = lines[-1].split(' ')[-1] ok = True if missing_list: print 'Missing tests for %s' % (', '.join(missing_list)) + print stdout ok = False if coverage != '100%': print stdout |