aboutsummaryrefslogtreecommitdiff
path: root/tools/patman/control.py
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2020-10-29 21:46:38 -0600
committerSimon Glass <sjg@chromium.org>2020-11-05 09:11:31 -0700
commitdc4b2a9770b5b932cd6d98c33ebff6dc46de6849 (patch)
tree9f4ffd9d309709ed2e134cea3609821350f98ed5 /tools/patman/control.py
parent6b3252e230a1b8ba763883a79906d69b9aa50415 (diff)
downloadu-boot-dc4b2a9770b5b932cd6d98c33ebff6dc46de6849.zip
u-boot-dc4b2a9770b5b932cd6d98c33ebff6dc46de6849.tar.gz
u-boot-dc4b2a9770b5b932cd6d98c33ebff6dc46de6849.tar.bz2
patman: Support listing comments from patchwork
While reviewing feedback it is helpful to see the review comments on the command line to check that each has been addressed. Add an option to support that. Update the workflow documentation to describe the new features. Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools/patman/control.py')
-rw-r--r--tools/patman/control.py11
1 files changed, 8 insertions, 3 deletions
diff --git a/tools/patman/control.py b/tools/patman/control.py
index 6ac258d..f4a6ca1 100644
--- a/tools/patman/control.py
+++ b/tools/patman/control.py
@@ -176,11 +176,13 @@ def send(args):
args.limit, args.dry_run, args.in_reply_to, args.thread,
args.smtp_server)
-def patchwork_status(branch, count, start, end, dest_branch, force):
+def patchwork_status(branch, count, start, end, dest_branch, force,
+ show_comments):
"""Check the status of patches in patchwork
This finds the series in patchwork using the Series-link tag, checks for new
- review tags, displays then and creates a new branch with the review tags.
+ comments and review tags, displays then and creates a new branch with the
+ review tags.
Args:
branch (str): Branch to create patches from (None = current)
@@ -192,6 +194,8 @@ def patchwork_status(branch, count, start, end, dest_branch, force):
dest_branch (str): Name of new branch to create with the updated tags
(None to not create a branch)
force (bool): With dest_branch, force overwriting an existing branch
+ show_comments (bool): True to display snippets from the comments
+ provided by reviewers
Raises:
ValueError: if the branch has no Series-link value
@@ -223,4 +227,5 @@ def patchwork_status(branch, count, start, end, dest_branch, force):
# Import this here to avoid failing on other commands if the dependencies
# are not present
from patman import status
- status.check_patchwork_status(series, found[0], branch, dest_branch, force)
+ status.check_patchwork_status(series, found[0], branch, dest_branch, force,
+ show_comments)