diff options
| author | Michal Simek <michal.simek@xilinx.com> | 2022-01-11 10:28:09 +0100 |
|---|---|---|
| committer | Michal Simek <michal.simek@xilinx.com> | 2022-01-11 10:33:42 +0100 |
| commit | 381e6e5494d422a2adcede3da9f967c22c6ad123 (patch) | |
| tree | e0d87fbb2b6f8bb53f67198e5834116b1d2b1b41 /net | |
| parent | 2a9caba1ceff85c7c07dcb43d48b4c8cf8c79f5e (diff) | |
| download | u-boot-381e6e5494d422a2adcede3da9f967c22c6ad123.zip u-boot-381e6e5494d422a2adcede3da9f967c22c6ad123.tar.gz u-boot-381e6e5494d422a2adcede3da9f967c22c6ad123.tar.bz2 | |
net: uclass: Save generated ethernet MAC addresses to the environment
When a MAC address is randomly generated we currently only update the
appropriate data structure. For consistency and to re-align with
historic usage, it should be also saved to the appropriate environment
variable as well.
Cc: Wolfgang Denk <wd@denx.de>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
[trini: Update Kconfig, handle legacy networking case as well]
Signed-off-by: Tom Rini <trini@konsulko.com>
Acked-by: Ramon Fried <rfried.dev@gmail.com>
Link: https://lore.kernel.org/r/1a2518e3cc19c14a41875ef64c5acc1f16edc813.1641893287.git.michal.simek@xilinx.com
Diffstat (limited to 'net')
| -rw-r--r-- | net/Kconfig | 9 | ||||
| -rw-r--r-- | net/eth-uclass.c | 2 | ||||
| -rw-r--r-- | net/eth_legacy.c | 2 |
3 files changed, 9 insertions, 4 deletions
diff --git a/net/Kconfig b/net/Kconfig index 7a2d145..cabe93c 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -27,10 +27,11 @@ config BOOTP_SEND_HOSTNAME config NET_RANDOM_ETHADDR bool "Random ethaddr if unset" help - Selecting this will allow the Ethernet interface to function - even when the ethaddr variable for that interface is unset. - A new MAC address will be generated on every boot and it will - not be added to the environment. + Selecting this will allow the Ethernet interface to function even + when the ethaddr variable for that interface is unset. In this case, + a random MAC address in the locally administered address space is + generated. It will be saved to the appropriate environment variable, + too. config NETCONSOLE bool "NetConsole support" diff --git a/net/eth-uclass.c b/net/eth-uclass.c index 0da0e85..58c308f 100644 --- a/net/eth-uclass.c +++ b/net/eth-uclass.c @@ -583,6 +583,8 @@ static int eth_post_probe(struct udevice *dev) net_random_ethaddr(pdata->enetaddr); printf("\nWarning: %s (eth%d) using random MAC address - %pM\n", dev->name, dev_seq(dev), pdata->enetaddr); + eth_env_set_enetaddr_by_index("eth", dev_seq(dev), + pdata->enetaddr); #else printf("\nError: %s address not set.\n", dev->name); diff --git a/net/eth_legacy.c b/net/eth_legacy.c index f383ccc..0b282d9 100644 --- a/net/eth_legacy.c +++ b/net/eth_legacy.c @@ -164,6 +164,8 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name, net_random_ethaddr(dev->enetaddr); printf("\nWarning: %s (eth%d) using random MAC address - %pM\n", dev->name, eth_number, dev->enetaddr); + eth_env_set_enetaddr_by_index("eth", eth_number, + dev->enetaddr); #else printf("\nError: %s address not set.\n", dev->name); |