diff options
| author | Simon Glass <sjg@chromium.org> | 2020-05-10 11:39:55 -0600 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-05-18 14:54:24 -0400 |
| commit | c3dc39a2f85b16bf590789f7e283cd72275cd168 (patch) | |
| tree | fd07b448aa4192e1d4fede43e412d5fdfa584b82 /include | |
| parent | b79fdc76978515fba2c4f3b5b4f2e679c5ff1463 (diff) | |
| download | u-boot-c3dc39a2f85b16bf590789f7e283cd72275cd168.zip u-boot-c3dc39a2f85b16bf590789f7e283cd72275cd168.tar.gz u-boot-c3dc39a2f85b16bf590789f7e283cd72275cd168.tar.bz2 | |
arm: Don't include common.h in header files
It is bad practice to include common.h in other header files since it can
bring in any number of superfluous definitions. It implies that some C
files don't include it and thus may be missing CONFIG options that are set
up by that file. The C files should include these themselves.
Update some header files in arch/arm to drop this.
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/compat.h | 1 | ||||
| -rw-r--r-- | include/linux/mtd/rawnand.h | 1 | ||||
| -rw-r--r-- | include/net.h | 6 | ||||
| -rw-r--r-- | include/spl.h | 2 |
4 files changed, 9 insertions, 1 deletions
diff --git a/include/linux/compat.h b/include/linux/compat.h index 171188a..712eeae 100644 --- a/include/linux/compat.h +++ b/include/linux/compat.h @@ -1,6 +1,7 @@ #ifndef _LINUX_COMPAT_H_ #define _LINUX_COMPAT_H_ +#include <log.h> #include <malloc.h> #include <linux/types.h> #include <linux/err.h> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index bd373b9..66febc6 100644 --- a/include/linux/mtd/rawnand.h +++ b/include/linux/mtd/rawnand.h @@ -16,6 +16,7 @@ #include <config.h> #include <dm/device.h> +#include <linux/bitops.h> #include <linux/compat.h> #include <linux/mtd/mtd.h> #include <linux/mtd/flashchip.h> diff --git a/include/net.h b/include/net.h index 82500ee..774ae2d 100644 --- a/include/net.h +++ b/include/net.h @@ -15,9 +15,13 @@ #include <asm/cache.h> #include <asm/byteorder.h> /* for nton* / ntoh* stuff */ #include <env.h> +#include <log.h> +#include <time.h> #include <linux/if_ether.h> #include <rand.h> +struct cmd_tbl_s; + #define DEBUG_LL_STATE 0 /* Link local state machine changes */ #define DEBUG_DEV_PKT 0 /* Packets or info directed to the device */ #define DEBUG_NET_PKT 0 /* Packets on info on the network at large */ @@ -59,7 +63,7 @@ struct in_addr { * @argv: List of arguments * @return result (see enum command_ret_t) */ -int do_tftpb(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]); +int do_tftpb(struct cmd_tbl_s *cmdtp, int flag, int argc, char *const argv[]); /** * An incoming packet handler. diff --git a/include/spl.h b/include/spl.h index 90395fe..5a67c82 100644 --- a/include/spl.h +++ b/include/spl.h @@ -26,6 +26,8 @@ struct image_header; #define MMCSD_MODE_FS 2 #define MMCSD_MODE_EMMCBOOT 3 +struct image_header; + /* * u_boot_first_phase() - check if this is the first U-Boot phase * |