diff options
| author | Heinrich Schuchardt <heinrich.schuchardt@canonical.com> | 2022-11-10 08:40:30 +0100 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2022-11-22 15:13:35 -0700 |
| commit | b3a680a47abfdd5fa4086bab53891f3a4e798d74 (patch) | |
| tree | 675c722a23dd8c1e35fba22baf7b7707edc97150 /drivers | |
| parent | 8dd0059f7797006a6bcbea1a3954dee27aa3473a (diff) | |
| download | u-boot-b3a680a47abfdd5fa4086bab53891f3a4e798d74.zip u-boot-b3a680a47abfdd5fa4086bab53891f3a4e798d74.tar.gz u-boot-b3a680a47abfdd5fa4086bab53891f3a4e798d74.tar.bz2 | |
sandbox: check lseek return value in handle_ufi_command
Invoking lseek() may result in an error. Handle it.
Addresses-Coverity-ID: 376212 ("Error handling issues (CHECKED_RETURN)")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/emul/sandbox_flash.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/usb/emul/sandbox_flash.c b/drivers/usb/emul/sandbox_flash.c index 6e8cfe1..01ccc4b 100644 --- a/drivers/usb/emul/sandbox_flash.c +++ b/drivers/usb/emul/sandbox_flash.c @@ -188,15 +188,19 @@ static int handle_ufi_command(struct sandbox_flash_priv *priv, const void *buff, struct scsi_emul_info *info = &priv->eminfo; const struct scsi_cmd *req = buff; int ret; + off_t offset; ret = sb_scsi_emul_command(info, req, len); if (!ret) { setup_response(priv); } else if ((ret == SCSI_EMUL_DO_READ || ret == SCSI_EMUL_DO_WRITE) && priv->fd != -1) { - os_lseek(priv->fd, info->seek_block * info->block_size, - OS_SEEK_SET); - setup_response(priv); + offset = os_lseek(priv->fd, info->seek_block * info->block_size, + OS_SEEK_SET); + if (offset == (off_t)-1) + setup_fail_response(priv); + else + setup_response(priv); } else { setup_fail_response(priv); } |