diff options
| author | Ilias Apalodimas <ilias.apalodimas@linaro.org> | 2023-04-07 12:13:00 +0300 |
|---|---|---|
| committer | Jagan Teki <jagan@amarulasolutions.com> | 2023-04-25 23:06:10 +0530 |
| commit | 8485595927e1685a8369426bda91b6a89dc2754c (patch) | |
| tree | a4ddd4c20bb8e3f08bf08edd2a3f45874f523b2e /drivers/spi | |
| parent | 24c27b3c6ceab7295d12cd2ae0a47cfe9c136ecc (diff) | |
| download | u-boot-8485595927e1685a8369426bda91b6a89dc2754c.zip u-boot-8485595927e1685a8369426bda91b6a89dc2754c.tar.gz u-boot-8485595927e1685a8369426bda91b6a89dc2754c.tar.bz2 | |
spi: synquacer: Silence uninitialized variable warnings
When building with clang, the compiler compains with
drivers/spi/spi-synquacer.c:212:11: warning: variable 'bus_width' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
else if (priv->mode & SPI_TX_OCTAL)
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/spi/spi-synquacer.c:276:11: note: uninitialized use occurs here
val |= ((bus_width >> 1) << BUS_WIDTH);
^~~~~~~~~
drivers/spi/spi-synquacer.c:212:7: note: remove the 'if' if its condition is always true
else if (priv->mode & SPI_TX_OCTAL)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/spi/spi-synquacer.c:189:25: note: initialize the variable 'bus_width' to silence this warning
So initialize bus_width to 1 and add a warning if none of the configured
modes matches
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-synquacer.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi-synquacer.c b/drivers/spi/spi-synquacer.c index 0cae3df..0f5d0a3 100644 --- a/drivers/spi/spi-synquacer.c +++ b/drivers/spi/spi-synquacer.c @@ -186,7 +186,7 @@ static void synquacer_spi_config(struct udevice *dev, void *rx, const void *tx) struct udevice *bus = dev->parent; struct synquacer_spi_priv *priv = dev_get_priv(bus); struct dm_spi_slave_plat *slave_plat = dev_get_parent_plat(dev); - u32 val, div, bus_width; + u32 val, div, bus_width = 1; int rwflag; rwflag = (rx ? 1 : 0) | (tx ? 2 : 0); @@ -211,6 +211,8 @@ static void synquacer_spi_config(struct udevice *dev, void *rx, const void *tx) bus_width = 4; else if (priv->mode & SPI_TX_OCTAL) bus_width = 8; + else + log_warning("SPI mode not configured, setting to byte mode\n"); div = DIV_ROUND_UP(125000000, priv->speed); |