diff options
| author | Adam Ford <aford173@gmail.com> | 2021-01-18 15:32:49 -0600 |
|---|---|---|
| committer | Jagan Teki <jagan@amarulasolutions.com> | 2021-02-26 15:09:38 +0530 |
| commit | 90d76f812b29c88f47279eca034da70d30a798d9 (patch) | |
| tree | 8e913c8296dd93e7573edb6ffd1661dc5001e127 /drivers/spi/nxp_fspi.c | |
| parent | de76ae36f622177e9af38b158d7f2f753d826d2c (diff) | |
| download | u-boot-90d76f812b29c88f47279eca034da70d30a798d9.zip u-boot-90d76f812b29c88f47279eca034da70d30a798d9.tar.gz u-boot-90d76f812b29c88f47279eca034da70d30a798d9.tar.bz2 | |
spi: nxp_fspi: Fix error reporting
On the i.MX8M Mini, ret = clk_set_rate() sets ret to the value of the
rate the clock was able to set. When checking for errors, it only
checks that it is not NULL. Since positive numbers are not errors,
only check for negative numbers when handling errors.
Fixes: 383fded70c4f ("spi: nxp_fspi: new driver for the FlexSPI controller")
Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
Diffstat (limited to 'drivers/spi/nxp_fspi.c')
| -rw-r--r-- | drivers/spi/nxp_fspi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c index 012f304..6c5bad4 100644 --- a/drivers/spi/nxp_fspi.c +++ b/drivers/spi/nxp_fspi.c @@ -823,7 +823,7 @@ static int nxp_fspi_default_setup(struct nxp_fspi *f) /* the default frequency, we will change it later if necessary. */ ret = clk_set_rate(&f->clk, 20000000); - if (ret) + if (ret < 0) return ret; ret = nxp_fspi_clk_prep_enable(f); @@ -914,7 +914,7 @@ static int nxp_fspi_set_speed(struct udevice *bus, uint speed) nxp_fspi_clk_disable_unprep(f); ret = clk_set_rate(&f->clk, speed); - if (ret) + if (ret < 0) return ret; ret = nxp_fspi_clk_prep_enable(f); |