aboutsummaryrefslogtreecommitdiff
path: root/drivers/power/axp209.c
diff options
context:
space:
mode:
authorOlliver Schinagl <oliver@schinagl.nl>2018-11-21 20:05:31 +0200
committerJagan Teki <jagan@amarulasolutions.com>2018-12-07 22:24:33 +0530
commitef52605ebeb4fa2a97454ab225db6514519427fb (patch)
treef36f06cd03b522d47fd25a32ec849217c7c21816 /drivers/power/axp209.c
parent61436d502b33854ddf33797670d4e25c0d79d540 (diff)
downloadu-boot-ef52605ebeb4fa2a97454ab225db6514519427fb.zip
u-boot-ef52605ebeb4fa2a97454ab225db6514519427fb.tar.gz
u-boot-ef52605ebeb4fa2a97454ab225db6514519427fb.tar.bz2
power: axp209: Limit inrush current for broken boards
Some boards feature a capacitance on LDO3's output that is too large, causing inrush currents which as a result, shut down the AXP209. This has been reported before, without knowing the actual cause. A fix appeared to be done with commit 0e6e34ac8dbb ("sunxi: Olimex A20 boards: Enable LDO3 and LDO4 regulators"). The description there is a bit misleading, the kernel does not hang during AXP209 initialization, the PMIC shuts down, causing voltages to drop and thus the whole system freezes. While the AXP209 does have the ability to ramp up the voltage slowly, to reduce these inrush currents, the voltage rate control (VRC) however is not applicable when switching on the LDO3 output. Only when going from an enabled lower voltage setting, to a higher voltage setting is the VRC in effect. To work around this problem, we set LDO3 to the lowest possible setting of 0.7 V if it was not yet enabled, and then let the VRC (if enabled) do its thing. It should be noted, that for some undocumented reason, there is a short delay needed between setting the LDO3 voltage register and enabling the power. One would expect that this delay ought to be just after enabling the output power at 0.7 V, but this did not work. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> Signed-off-by: Priit Laes <plaes@plaes.org> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Diffstat (limited to 'drivers/power/axp209.c')
-rw-r--r--drivers/power/axp209.c23
1 files changed, 23 insertions, 0 deletions
diff --git a/drivers/power/axp209.c b/drivers/power/axp209.c
index cf138fc..67b4209 100644
--- a/drivers/power/axp209.c
+++ b/drivers/power/axp209.c
@@ -122,6 +122,29 @@ int axp_set_aldo3(unsigned int mvolt)
if (rc)
return rc;
+#ifdef CONFIG_AXP_ALDO3_INRUSH_QUIRK
+ /*
+ * On some boards, LDO3 has a too big capacitor installed. When
+ * turning on LDO3, this causes the AXP209 to shutdown on
+ * voltages over 1.9 volt. As a workaround, we enable LDO3
+ * first with the lowest possible voltage. If this still causes
+ * high inrush currents, the voltage slope should be increased.
+ */
+ rc = pmic_bus_read(AXP209_OUTPUT_CTRL, &cfg);
+ if (rc)
+ return rc;
+
+ if (!(cfg & AXP209_OUTPUT_CTRL_LDO3)) {
+ rc = pmic_bus_write(AXP209_LDO3_VOLTAGE, 0x0); /* 0.7 Volt */
+ mdelay(1);
+ rc |= pmic_bus_setbits(AXP209_OUTPUT_CTRL,
+ AXP209_OUTPUT_CTRL_LDO3);
+
+ if (rc)
+ return rc;
+ }
+#endif
+
if (mvolt == -1) {
cfg = AXP209_LDO3_VOLTAGE_FROM_LDO3IN;
} else {