diff options
| author | Marek Vasut <marex@denx.de> | 2023-07-16 17:53:24 +0200 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2023-08-14 17:55:52 -0400 |
| commit | 8ee830d8983763575aad62c37394ec954a76abc4 (patch) | |
| tree | 860aea4c54fbfa4359dfa6f13c437ad513377c80 /drivers/pci | |
| parent | b99c6357877da2829dc7fd73a50048e83abc53e2 (diff) | |
| download | u-boot-8ee830d8983763575aad62c37394ec954a76abc4.zip u-boot-8ee830d8983763575aad62c37394ec954a76abc4.tar.gz u-boot-8ee830d8983763575aad62c37394ec954a76abc4.tar.bz2 | |
pci: Fix device_find_first_child() return value handling
This function only ever returns 0, but may not assign the second
parameter. Same thing for device_find_next_child(). Do not assign
ret to stop proliferation of this misuse.
Reported-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/pci')
| -rw-r--r-- | drivers/pci/pci-uclass.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index 7f3d6dd..0adcdce 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -541,14 +541,13 @@ int pci_auto_config_devices(struct udevice *bus) struct pci_child_plat *pplat; unsigned int sub_bus; struct udevice *dev; - int ret; sub_bus = dev_seq(bus); debug("%s: start\n", __func__); pciauto_config_init(hose); - for (ret = device_find_first_child(bus, &dev); - !ret && dev; - ret = device_find_next_child(&dev)) { + for (device_find_first_child(bus, &dev); + dev; + device_find_next_child(&dev)) { unsigned int max_bus; int ret; |