diff options
| author | Marek Behún <marek.behun@nic.cz> | 2022-04-07 00:33:01 +0200 |
|---|---|---|
| committer | Ramon Fried <ramon@neureality.ai> | 2022-04-10 08:44:12 +0300 |
| commit | 123ca114e07ecf28aa2538748d733e2b22d8b8b5 (patch) | |
| tree | 0a5481e51e4e50b33daf4d10f37574f6f797b04f /drivers/net/pic32_eth.c | |
| parent | 9c06b4815ce1d663085c214133762614bba79fbe (diff) | |
| download | u-boot-123ca114e07ecf28aa2538748d733e2b22d8b8b5.zip u-boot-123ca114e07ecf28aa2538748d733e2b22d8b8b5.tar.gz u-boot-123ca114e07ecf28aa2538748d733e2b22d8b8b5.tar.bz2 | |
net: introduce helpers to get PHY interface mode from a device/ofnode
Add helpers ofnode_read_phy_mode() and dev_read_phy_mode() to parse the
"phy-mode" / "phy-connection-type" property. Add corresponding UT test.
Use them treewide.
This allows us to inline the phy_get_interface_by_name() into
ofnode_read_phy_mode(), since the former is not used anymore.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Tested-by: Patrice Chotard <patrice.chotard@foss.st.com>
Diffstat (limited to 'drivers/net/pic32_eth.c')
| -rw-r--r-- | drivers/net/pic32_eth.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/drivers/net/pic32_eth.c b/drivers/net/pic32_eth.c index 5a678d1..03eb51e 100644 --- a/drivers/net/pic32_eth.c +++ b/drivers/net/pic32_eth.c @@ -534,7 +534,6 @@ static int pic32_eth_probe(struct udevice *dev) { struct eth_pdata *pdata = dev_get_plat(dev); struct pic32eth_dev *priv = dev_get_priv(dev); - const char *phy_mode; void __iomem *iobase; fdt_addr_t addr; fdt_size_t size; @@ -550,15 +549,9 @@ static int pic32_eth_probe(struct udevice *dev) pdata->iobase = (phys_addr_t)addr; /* get phy mode */ - pdata->phy_interface = -1; - phy_mode = fdt_getprop(gd->fdt_blob, dev_of_offset(dev), "phy-mode", - NULL); - if (phy_mode) - pdata->phy_interface = phy_get_interface_by_name(phy_mode); - if (pdata->phy_interface == -1) { - debug("%s: Invalid PHY interface '%s'\n", __func__, phy_mode); + pdata->phy_interface = dev_read_phy_mode(dev); + if (pdata->phy_interface == PHY_INTERFACE_MODE_NONE) return -EINVAL; - } /* get phy addr */ offset = fdtdec_lookup_phandle(gd->fdt_blob, dev_of_offset(dev), |