diff options
| author | Patrick Delaunay <patrick.delaunay@st.com> | 2017-07-19 16:39:22 +0200 |
|---|---|---|
| committer | Marek Vasut <marex@denx.de> | 2017-07-28 23:34:38 +0200 |
| commit | 4de512018ba7d57f1672be21c7459281f7c97514 (patch) | |
| tree | ca142a43fc4dde3780e35568eedbbe26dbeec39c /drivers/dfu/dfu_mmc.c | |
| parent | bab0146ea91146aafa8cf10a34a45ae85eca5683 (diff) | |
| download | u-boot-4de512018ba7d57f1672be21c7459281f7c97514.zip u-boot-4de512018ba7d57f1672be21c7459281f7c97514.tar.gz u-boot-4de512018ba7d57f1672be21c7459281f7c97514.tar.bz2 | |
dfu: allow dfu read on partition greater than 2GB
solve issue on get_medium_size() function
the detection of error is a simple test < 0
but for ARM platform, long is 32bits and 2GB = 0x80000000
is seen as error.
I solve the issue by changing the prototype fo the function
to separate size and result.
This patch prepare the next patch with size change to u64.
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Diffstat (limited to 'drivers/dfu/dfu_mmc.c')
| -rw-r--r-- | drivers/dfu/dfu_mmc.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c index 926ccbd..d918f95 100644 --- a/drivers/dfu/dfu_mmc.c +++ b/drivers/dfu/dfu_mmc.c @@ -209,23 +209,23 @@ int dfu_flush_medium_mmc(struct dfu_entity *dfu) return ret; } -long dfu_get_medium_size_mmc(struct dfu_entity *dfu) +int dfu_get_medium_size_mmc(struct dfu_entity *dfu, long *size) { int ret; - long len; switch (dfu->layout) { case DFU_RAW_ADDR: - return dfu->data.mmc.lba_size * dfu->data.mmc.lba_blk_size; + *size = dfu->data.mmc.lba_size * dfu->data.mmc.lba_blk_size; + return 0; case DFU_FS_FAT: case DFU_FS_EXT4: dfu_file_buf_filled = -1; - ret = mmc_file_op(DFU_OP_SIZE, dfu, NULL, &len); + ret = mmc_file_op(DFU_OP_SIZE, dfu, NULL, size); if (ret < 0) return ret; - if (len > CONFIG_SYS_DFU_MAX_FILE_SIZE) + if (*size > CONFIG_SYS_DFU_MAX_FILE_SIZE) return -1; - return len; + return 0; default: printf("%s: Layout (%s) not (yet) supported!\n", __func__, dfu_get_layout(dfu->layout)); |