aboutsummaryrefslogtreecommitdiff
path: root/common
diff options
context:
space:
mode:
authorThierry Reding <treding@nvidia.com>2015-08-20 11:45:43 +0200
committerTom Rini <trini@konsulko.com>2015-08-28 11:46:35 -0400
commit9734b97f76a942f449fdc9ff445a003aa812baa7 (patch)
treeedb082a39510c383469583d1f35165acea9adf0f /common
parent79c884d7e449a63fa8f07b7495f8f9873355c48f (diff)
downloadu-boot-9734b97f76a942f449fdc9ff445a003aa812baa7.zip
u-boot-9734b97f76a942f449fdc9ff445a003aa812baa7.tar.gz
u-boot-9734b97f76a942f449fdc9ff445a003aa812baa7.tar.bz2
image: Fix loop condition to avoid warning
GCC 5.1 starts warning for comparisons such as !a > 0, assuming that the negation was meant to apply to the whole expression rather than just the left operand. Indeed the comparison in the FIT loadable code is confusingly written, though it does end up doing the right thing. Rewrite the condition to be more explicit, that is, iterate over strings until they're exhausted. Signed-off-by: Thierry Reding <treding@nvidia.com> Reviewed-by: Tom Rini <trini@konsulko.com> Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'common')
-rw-r--r--common/image.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/common/image.c b/common/image.c
index ca721c5..678588d 100644
--- a/common/image.c
+++ b/common/image.c
@@ -1215,10 +1215,10 @@ int boot_get_loadable(int argc, char * const argv[], bootm_headers_t *images,
conf_noffset = fit_conf_get_node(buf, images->fit_uname_cfg);
for (loadables_index = 0;
- !fdt_get_string_index(buf, conf_noffset,
+ fdt_get_string_index(buf, conf_noffset,
FIT_LOADABLE_PROP,
loadables_index,
- (const char **)&uname) > 0;
+ (const char **)&uname) == 0;
loadables_index++)
{
fit_img_result = fit_image_load(images,