diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/renesas | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.zip u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.bz2 |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/renesas')
-rw-r--r-- | board/renesas/MigoR/migo_r.c | 2 | ||||
-rw-r--r-- | board/renesas/blanche/blanche.c | 2 | ||||
-rw-r--r-- | board/renesas/r2dplus/r2dplus.c | 2 | ||||
-rw-r--r-- | board/renesas/r7780mp/r7780mp.c | 2 | ||||
-rw-r--r-- | board/renesas/rcar-common/common.c | 2 | ||||
-rw-r--r-- | board/renesas/sh7752evb/sh7752evb.c | 2 | ||||
-rw-r--r-- | board/renesas/sh7753evb/sh7753evb.c | 2 | ||||
-rw-r--r-- | board/renesas/sh7757lcr/sh7757lcr.c | 2 |
8 files changed, 8 insertions, 8 deletions
diff --git a/board/renesas/MigoR/migo_r.c b/board/renesas/MigoR/migo_r.c index f8bdb4d..f2f4c65 100644 --- a/board/renesas/MigoR/migo_r.c +++ b/board/renesas/MigoR/migo_r.c @@ -32,7 +32,7 @@ void led_set_state (unsigned short value) } #ifdef CONFIG_CMD_NET -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rc = 0; #ifdef CONFIG_SMC91111 diff --git a/board/renesas/blanche/blanche.c b/board/renesas/blanche/blanche.c index 5fa1087..2450fca 100644 --- a/board/renesas/blanche/blanche.c +++ b/board/renesas/blanche/blanche.c @@ -318,7 +318,7 @@ int board_init(void) /* Added for BLANCHE(R-CarV2H board) */ #ifndef CONFIG_DM_ETH -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rc = 0; diff --git a/board/renesas/r2dplus/r2dplus.c b/board/renesas/r2dplus/r2dplus.c index 0bbdb0e..4b9959a 100644 --- a/board/renesas/r2dplus/r2dplus.c +++ b/board/renesas/r2dplus/r2dplus.c @@ -47,7 +47,7 @@ void ide_set_reset(int idereset) } #ifndef CONFIG_DM_ETH -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { return pci_eth_init(bis); } diff --git a/board/renesas/r7780mp/r7780mp.c b/board/renesas/r7780mp/r7780mp.c index 120464c..422381c 100644 --- a/board/renesas/r7780mp/r7780mp.c +++ b/board/renesas/r7780mp/r7780mp.c @@ -57,7 +57,7 @@ void pci_init_board(void) pci_sh7780_init(&hose); } -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { /* return >= 0 if a chip is found, the board's AX88796L is n2k-based */ return ne2k_register() + pci_eth_init(bis); diff --git a/board/renesas/rcar-common/common.c b/board/renesas/rcar-common/common.c index 46dcea1..9f50f36 100644 --- a/board/renesas/rcar-common/common.c +++ b/board/renesas/rcar-common/common.c @@ -44,7 +44,7 @@ int dram_init_banksize(void) } #if CONFIG_IS_ENABLED(OF_BOARD_SETUP) && CONFIG_IS_ENABLED(PCI) -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { struct udevice *dev; struct uclass *uc; diff --git a/board/renesas/sh7752evb/sh7752evb.c b/board/renesas/sh7752evb/sh7752evb.c index a005029..522b4bd 100644 --- a/board/renesas/sh7752evb/sh7752evb.c +++ b/board/renesas/sh7752evb/sh7752evb.c @@ -164,7 +164,7 @@ int board_init(void) return 0; } -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { struct gpio_regs *gpio = GPIO_BASE; diff --git a/board/renesas/sh7753evb/sh7753evb.c b/board/renesas/sh7753evb/sh7753evb.c index 3b4a3ce..f34dec1 100644 --- a/board/renesas/sh7753evb/sh7753evb.c +++ b/board/renesas/sh7753evb/sh7753evb.c @@ -180,7 +180,7 @@ int board_init(void) return 0; } -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { struct gpio_regs *gpio = GPIO_BASE; diff --git a/board/renesas/sh7757lcr/sh7757lcr.c b/board/renesas/sh7757lcr/sh7757lcr.c index 5e76b9e..e933e3e 100644 --- a/board/renesas/sh7757lcr/sh7757lcr.c +++ b/board/renesas/sh7757lcr/sh7757lcr.c @@ -233,7 +233,7 @@ int board_init(void) return 0; } -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { return mmcif_mmc_init(); } |