diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/phytec | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
| download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.zip u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.bz2 | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/phytec')
| -rw-r--r-- | board/phytec/pcl063/spl.c | 2 | ||||
| -rw-r--r-- | board/phytec/pfla02/pfla02.c | 6 | ||||
| -rw-r--r-- | board/phytec/phycore_am335x_r2/board.c | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/board/phytec/pcl063/spl.c b/board/phytec/pcl063/spl.c index 48cb2e2..fea4aa3 100644 --- a/board/phytec/pcl063/spl.c +++ b/board/phytec/pcl063/spl.c @@ -152,7 +152,7 @@ int board_mmc_getcd(struct mmc *mmc) return 1; } -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { int i, ret; diff --git a/board/phytec/pfla02/pfla02.c b/board/phytec/pfla02/pfla02.c index 0a961cc..3b10cc0 100644 --- a/board/phytec/pfla02/pfla02.c +++ b/board/phytec/pfla02/pfla02.c @@ -212,7 +212,7 @@ int board_mmc_getcd(struct mmc *mmc) } #ifndef CONFIG_SPL_BUILD -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { int ret; int i; @@ -332,7 +332,7 @@ int board_spi_cs_gpio(unsigned bus, unsigned cs) return IMX_GPIO_NR(4, 24); } -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { setup_iomux_enet(); @@ -562,7 +562,7 @@ static void spl_dram_init(struct mx6_ddr_sysinfo *sysinfo, mx6_dram_cfg(sysinfo, &mx6_mmcd_calib, mem_ddr); } -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { if (spl_boot_device() == BOOT_DEVICE_SPI) printf("MMC SEtup, Boot SPI"); diff --git a/board/phytec/phycore_am335x_r2/board.c b/board/phytec/phycore_am335x_r2/board.c index 8964fb5..fb58906 100644 --- a/board/phytec/phycore_am335x_r2/board.c +++ b/board/phytec/phycore_am335x_r2/board.c @@ -247,7 +247,7 @@ int board_init(void) } #ifdef CONFIG_OF_BOARD_SETUP -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { #ifdef CONFIG_FDT_FIXUP_PARTITIONS static const struct node_info nodes[] = { |