diff options
| author | Andre Przywara <andre.przywara@arm.com> | 2024-01-02 15:02:51 +0000 |
|---|---|---|
| committer | Andre Przywara <andre.przywara@arm.com> | 2024-04-22 01:12:25 +0100 |
| commit | 1a6828d0c54da2267cfc2a8abe7c51226f1cb80f (patch) | |
| tree | 0ecd9653368b5029593858692962b897a8910daf | |
| parent | 02780a1c2675916bea8dbfb594bba7936ff538d5 (diff) | |
| download | u-boot-1a6828d0c54da2267cfc2a8abe7c51226f1cb80f.zip u-boot-1a6828d0c54da2267cfc2a8abe7c51226f1cb80f.tar.gz u-boot-1a6828d0c54da2267cfc2a8abe7c51226f1cb80f.tar.bz2 | |
sunxi: remove unneeded i2c_init_board() call for U-Boot proper
The driver used for the Allwinner I2C IP is using proper DT and DM
enablement for a while: we enable the clock gate and de-assert the reset
line in the driver's probe() routine, and the pinmux setup is taken care
of by the DM framework.
This means the explicit call to the i2c_init_board() routine is not
needed for U-Boot proper. As the board_init() function in board.c is
only called for U-Boot proper, we can remove the call, something that
the comment there hinted at already.
Fix the comment for the board_init() function on the way: we were not
really doing board specific setup there. The fact that this function
is called from U-Boot proper only is probably more helpful for reasoning
about this code.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
| -rw-r--r-- | board/sunxi/board.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/board/sunxi/board.c b/board/sunxi/board.c index 8c12c8d..1313b01 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -186,7 +186,7 @@ enum env_location env_get_location(enum env_operation op, int prio) return ENVL_UNKNOWN; } -/* add board specific code here */ +/* called only from U-Boot proper */ int board_init(void) { __maybe_unused int id_pfr1, ret; @@ -226,13 +226,6 @@ int board_init(void) if (ret) return ret; -#if CONFIG_IS_ENABLED(DM_I2C) - /* - * Temporary workaround for enabling I2C clocks until proper sunxi DM - * clk, reset and pinctrl drivers land. - */ - i2c_init_board(); -#endif eth_init_board(); return 0; |