aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPegorer Massimo <Massimo.Pegorer@vimar.com>2023-07-15 10:19:34 +0000
committerKever Yang <kever.yang@rock-chips.com>2023-07-31 14:38:51 +0800
commit9f2c7349e516a082b13ded4ae0efd3ce448c8970 (patch)
tree14ebc922a106f10a11a6591b28676359584d51f8
parentaff236f30d51eee12eba86b49877ea643f374cd5 (diff)
downloadu-boot-9f2c7349e516a082b13ded4ae0efd3ce448c8970.zip
u-boot-9f2c7349e516a082b13ded4ae0efd3ce448c8970.tar.gz
u-boot-9f2c7349e516a082b13ded4ae0efd3ce448c8970.tar.bz2
rockchip: rk3308: no DEBUG_UART_BOARD_INIT for ROCK Pi S
Call to board_debug_uart_init() is useless, as mainline U-Boot can not build TPL for rk3308, and proprietary ddr.bin to be used as TPL is responsible to init debug uart. Moreover current implementation of board_debug_uart_init() is not compatible with ROCK Pi S, as it sets pins for UART2 channel 1 breaking access to sdmmc due to pinmux conflict. Debug uart for ROCK Pi S is UART0. Thus, avoid ROCKCHIP_RK3308 to select DEBUG_UART_BOARD_INIT and allow to deselct it in rock-pi-s-rk3308_defconfig. The DEBUG_UART_BOARD_INIT is already implied by ARCH_ROCKCHIP, therefore other boards based on rk3308 chip are not affected by change. Signed-off-by: Massimo Pegorer <massimo.pegorer@vimar.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
-rw-r--r--arch/arm/mach-rockchip/Kconfig1
-rw-r--r--configs/rock-pi-s-rk3308_defconfig1
2 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 07b5595..49da93d 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -153,7 +153,6 @@ config ROCKCHIP_RK3288
config ROCKCHIP_RK3308
bool "Support Rockchip RK3308"
select ARM64
- select DEBUG_UART_BOARD_INIT
select SUPPORT_SPL
select SUPPORT_TPL
select SPL
diff --git a/configs/rock-pi-s-rk3308_defconfig b/configs/rock-pi-s-rk3308_defconfig
index c6fae07..d306b58 100644
--- a/configs/rock-pi-s-rk3308_defconfig
+++ b/configs/rock-pi-s-rk3308_defconfig
@@ -18,6 +18,7 @@ CONFIG_SPL_STACK_R_ADDR=0xc00000
CONFIG_SPL_STACK=0x400000
CONFIG_DEBUG_UART_BASE=0xFF0A0000
CONFIG_DEBUG_UART_CLOCK=24000000
+# CONFIG_DEBUG_UART_BOARD_INIT is not set
CONFIG_SYS_LOAD_ADDR=0xc00800
CONFIG_DEBUG_UART=y
CONFIG_ANDROID_BOOT_IMAGE=y