aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Rini <trini@konsulko.com>2023-04-05 19:48:57 -0400
committerTom Rini <trini@konsulko.com>2023-04-25 15:31:27 -0400
commit73b39a76e34a3b88a7a2c58588c9a5a604a51d90 (patch)
treeed8bc5f51d5d89007b28ba3ceb637a0730dc9949
parent51a765b37671b4460fdefef5000b9eb6988fddc8 (diff)
downloadu-boot-73b39a76e34a3b88a7a2c58588c9a5a604a51d90.zip
u-boot-73b39a76e34a3b88a7a2c58588c9a5a604a51d90.tar.gz
u-boot-73b39a76e34a3b88a7a2c58588c9a5a604a51d90.tar.bz2
usb: gadget: f_mass_storage: Rework do_request_sense slightly
When building with clang, it notes that sdinfo may be unused uninitialized in some cases. This appears to be true from reading the code, and we can simply set the variable to zero to start with and be as correct as before. Signed-off-by: Tom Rini <trini@konsulko.com> Reviewed-by: Marek Vasut <marex@denx.de>
-rw-r--r--drivers/usb/gadget/f_mass_storage.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
index 45f0504..f46829e 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -1117,7 +1117,7 @@ static int do_request_sense(struct fsg_common *common, struct fsg_buffhd *bh)
{
struct fsg_lun *curlun = &common->luns[common->lun];
u8 *buf = (u8 *) bh->buf;
- u32 sd, sdinfo;
+ u32 sd, sdinfo = 0;
int valid;
/*
@@ -1145,7 +1145,6 @@ static int do_request_sense(struct fsg_common *common, struct fsg_buffhd *bh)
if (!curlun) { /* Unsupported LUNs are okay */
common->bad_lun_okay = 1;
sd = SS_LOGICAL_UNIT_NOT_SUPPORTED;
- sdinfo = 0;
valid = 0;
} else {
sd = curlun->sense_data;