aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Rini <trini@konsulko.com>2023-02-22 13:36:29 -0500
committerTom Rini <trini@konsulko.com>2023-02-22 13:36:29 -0500
commit8c39999acb726ef083d3d5de12f20318ee0e5070 (patch)
tree0c63c50e69eefbc3e222c0484483557e2dc2a989
parent504feed90590ff5f33090fa818a802ba05ee51dd (diff)
parent237d1f60b1db52074441bc3a5848fe98503726a2 (diff)
downloadu-boot-8c39999acb726ef083d3d5de12f20318ee0e5070.zip
u-boot-8c39999acb726ef083d3d5de12f20318ee0e5070.tar.gz
u-boot-8c39999acb726ef083d3d5de12f20318ee0e5070.tar.bz2
Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-usbWIP/22Feb2023
- DWC3 bugfix
-rw-r--r--drivers/usb/dwc3/dwc3-generic.c38
1 files changed, 19 insertions, 19 deletions
diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
index 7896671..ed1b9b6 100644
--- a/drivers/usb/dwc3/dwc3-generic.c
+++ b/drivers/usb/dwc3/dwc3-generic.c
@@ -44,7 +44,7 @@ struct dwc3_generic_priv {
void *base;
struct dwc3 dwc3;
struct phy_bulk phys;
- struct gpio_desc ulpi_reset;
+ struct gpio_desc *ulpi_reset;
};
struct dwc3_generic_host_priv {
@@ -91,23 +91,23 @@ static int dwc3_generic_probe(struct udevice *dev,
if (CONFIG_IS_ENABLED(DM_GPIO) &&
device_is_compatible(dev->parent, "xlnx,zynqmp-dwc3")) {
- rc = gpio_request_by_name(dev->parent, "reset-gpios", 0,
- &priv->ulpi_reset, GPIOD_ACTIVE_LOW);
- if (rc)
- return rc;
-
- /* Toggle ulpi to reset the phy. */
- rc = dm_gpio_set_value(&priv->ulpi_reset, 1);
- if (rc)
- return rc;
-
- mdelay(5);
-
- rc = dm_gpio_set_value(&priv->ulpi_reset, 0);
- if (rc)
- return rc;
-
- mdelay(5);
+ priv->ulpi_reset = devm_gpiod_get_optional(dev->parent, "reset",
+ GPIOD_ACTIVE_LOW);
+ /* property is optional, don't return error! */
+ if (priv->ulpi_reset) {
+ /* Toggle ulpi to reset the phy. */
+ rc = dm_gpio_set_value(priv->ulpi_reset, 1);
+ if (rc)
+ return rc;
+
+ mdelay(5);
+
+ rc = dm_gpio_set_value(priv->ulpi_reset, 0);
+ if (rc)
+ return rc;
+
+ mdelay(5);
+ }
}
if (device_is_compatible(dev->parent, "rockchip,rk3399-dwc3"))
@@ -133,7 +133,7 @@ static int dwc3_generic_remove(struct udevice *dev,
if (CONFIG_IS_ENABLED(DM_GPIO) &&
device_is_compatible(dev->parent, "xlnx,zynqmp-dwc3")) {
- struct gpio_desc *ulpi_reset = &priv->ulpi_reset;
+ struct gpio_desc *ulpi_reset = priv->ulpi_reset;
dm_gpio_free(ulpi_reset->dev, ulpi_reset);
}