diff options
| author | Matthias Schiffer <matthias.schiffer@ew.tq-group.com> | 2021-07-30 14:23:54 +0200 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2021-10-12 16:48:38 -0400 |
| commit | 5f9338ad56e6b1168905e73ecfcd5e1b7b1a32e2 (patch) | |
| tree | 184249a4abc8d83ac446fc66eb237c0f7b3c067b | |
| parent | 776bf6a5457eb0c61c367d1ee7e45733a1c72ed6 (diff) | |
| download | u-boot-5f9338ad56e6b1168905e73ecfcd5e1b7b1a32e2.zip u-boot-5f9338ad56e6b1168905e73ecfcd5e1b7b1a32e2.tar.gz u-boot-5f9338ad56e6b1168905e73ecfcd5e1b7b1a32e2.tar.bz2 | |
fastboot: fix partition name truncation in environment lookup
strlcat() need to be passed the full buffer length. The incorrect call
caused truncation of partition names for fastboot_raw_partition_... and
fastboot_partition_alias_... env lookup to much less than PART_NAME_LEN.
Fixes: 69a752983171 ("fastboot: Fix possible buffer overrun")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Sean Anderson <seanga2@gmail.com>
| -rw-r--r-- | drivers/fastboot/fb_mmc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c index cbb3f7b..2738dc8 100644 --- a/drivers/fastboot/fb_mmc.c +++ b/drivers/fastboot/fb_mmc.c @@ -40,7 +40,7 @@ static int raw_part_get_info_by_name(struct blk_desc *dev_desc, /* check for raw partition descriptor */ strcpy(env_desc_name, "fastboot_raw_partition_"); - strlcat(env_desc_name, name, PART_NAME_LEN); + strlcat(env_desc_name, name, sizeof(env_desc_name)); raw_part_desc = strdup(env_get(env_desc_name)); if (raw_part_desc == NULL) return -ENODEV; @@ -114,7 +114,7 @@ static int part_get_info_by_name_or_alias(struct blk_desc **dev_desc, /* check for alias */ strcpy(env_alias_name, "fastboot_partition_alias_"); - strlcat(env_alias_name, name, PART_NAME_LEN); + strlcat(env_alias_name, name, sizeof(env_alias_name)); aliased_part_name = env_get(env_alias_name); if (aliased_part_name != NULL) ret = do_get_part_info(dev_desc, aliased_part_name, |