aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFabio Estevam <festevam@gmail.com>2024-03-12 21:59:41 -0300
committerFabio Estevam <festevam@gmail.com>2024-03-17 17:59:50 -0300
commitcd7af7ee5a06b367fb0f866346ea82c69b96e2f8 (patch)
treed5efde0396d201988e7eb05e271af51b3d42b787
parentfdd529fa624e8b235a949b63b932d3eb1e9641b9 (diff)
downloadu-boot-cd7af7ee5a06b367fb0f866346ea82c69b96e2f8.zip
u-boot-cd7af7ee5a06b367fb0f866346ea82c69b96e2f8.tar.gz
u-boot-cd7af7ee5a06b367fb0f866346ea82c69b96e2f8.tar.bz2
apalis-imx8: Fix sc_misc_otp_fuse_read() error check
Commit bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage") made an incorrect logic change in the error code check of sc_misc_otp_fuse_read(): - if (scierr == SC_ERR_NONE) { + if (scierr) { /* QP has one A72 core disabled */ is_quadplus = ((val >> 4) & 0x3) != 0x0; } The other changes in this commit are correct. sc_misc_otp_fuse_read() returns 0 on a successful fuse read. This inversion causes board_mem_get_layout() to report incorrect RAM size. Go back the original error check logic to fix the problem. Fixes: bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage") Signed-off-by: Fabio Estevam <festevam@gmail.com> Reviewed-by: Peng Fan <peng.fan@nxp.com> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
-rw-r--r--board/toradex/apalis-imx8/apalis-imx8.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/board/toradex/apalis-imx8/apalis-imx8.c b/board/toradex/apalis-imx8/apalis-imx8.c
index 2483a63..49719f2 100644
--- a/board/toradex/apalis-imx8/apalis-imx8.c
+++ b/board/toradex/apalis-imx8/apalis-imx8.c
@@ -133,7 +133,7 @@ void board_mem_get_layout(u64 *phys_sdram_1_start,
struct tdx_user_fuses tdxramfuses;
int scierr = sc_misc_otp_fuse_read(-1, 6, &val);
- if (scierr) {
+ if (!scierr) {
/* QP has one A72 core disabled */
is_quadplus = ((val >> 4) & 0x3) != 0x0;
}