diff options
| author | Simon Glass <sjg@chromium.org> | 2023-03-10 12:47:23 -0800 |
|---|---|---|
| committer | Heinrich Schuchardt <heinrich.schuchardt@canonical.com> | 2023-03-13 13:53:01 +0100 |
| commit | 61a621054194216eefc1a6f5af0a63aa265bbaef (patch) | |
| tree | 50d264f36cd5417e9af5e3b7ed5800f34b8c1320 | |
| parent | b7adb69e9a20c2f4ea5c184d057f792efc693b03 (diff) | |
| download | u-boot-61a621054194216eefc1a6f5af0a63aa265bbaef.zip u-boot-61a621054194216eefc1a6f5af0a63aa265bbaef.tar.gz u-boot-61a621054194216eefc1a6f5af0a63aa265bbaef.tar.bz2 | |
video: Add a note about the broken implementation
The cls command is broken. Previous discussion about this was at [1] and
[2]. For now, add a note to the source code.
[1] https://patchwork.ozlabs.org/project/uboot/patch/
20221022092058.106052-1-heinrich.schuchardt@canonical.com/
[2] https://patchwork.ozlabs.org/project/uboot/patch/
20230106145243.411626-12-sjg@chromium.org/
Signed-off-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | cmd/cls.c | 8 |
1 files changed, 7 insertions, 1 deletions
@@ -17,7 +17,13 @@ static int do_video_clear(struct cmd_tbl *cmdtp, int flag, int argc, { __maybe_unused struct udevice *dev; - /* Send clear screen and home */ + /* + * Send clear screen and home + * + * FIXME(Heinrich Schuchardt <xypron.glpk@gmx.de>): This should go + * through an API and only be written to serial terminals, not video + * displays + */ printf(CSI "2J" CSI "1;1H"); if (IS_ENABLED(CONFIG_VIDEO_ANSI)) return 0; |