diff options
| author | Bhupesh Sharma <bhupesh.sharma@linaro.org> | 2023-07-03 00:39:12 +0530 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2023-07-14 12:53:27 -0400 |
| commit | 33f70631abf37326930a8f67d1d71ca432d0e9a4 (patch) | |
| tree | 068a3173f73dffca822a8a3a1484707af99dba70 | |
| parent | db1ba81176f05756a8b3e1c14c97d9f39f15f85c (diff) | |
| download | u-boot-33f70631abf37326930a8f67d1d71ca432d0e9a4.zip u-boot-33f70631abf37326930a8f67d1d71ca432d0e9a4.tar.gz u-boot-33f70631abf37326930a8f67d1d71ca432d0e9a4.tar.bz2 | |
ufs: Use 'TASK_TAG' to construct the ucd_req_ptr->header.dword_0
Instead of using the hard-coded value of 0x1f, use 'TASK_TAG'
macro instead to construct the ucd_req_ptr->header.dword_0
This is in sync with what the Linux UFS driver does, i.e.
set the byte0 equal to TASK_TAG (see [1]).
Setting it to a fixed value of 0x1f is wrong as we define
TASK_TAG as 0 inside u-boot ufs framework. So, instead we
should use the macro value directly.
[1]. https://github.com/torvalds/linux/blob/master/drivers/ufs/core/ufshcd.c#L2705
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
| -rw-r--r-- | drivers/ufs/ufs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ufs/ufs.c b/drivers/ufs/ufs.c index 8dd29ed..3bf1a95 100644 --- a/drivers/ufs/ufs.c +++ b/drivers/ufs/ufs.c @@ -775,7 +775,7 @@ static inline void ufshcd_prepare_utp_nop_upiu(struct ufs_hba *hba) /* command descriptor fields */ ucd_req_ptr->header.dword_0 = - UPIU_HEADER_DWORD(UPIU_TRANSACTION_NOP_OUT, 0, 0, 0x1f); + UPIU_HEADER_DWORD(UPIU_TRANSACTION_NOP_OUT, 0, 0, TASK_TAG); /* clear rest of the fields of basic header */ ucd_req_ptr->header.dword_1 = 0; ucd_req_ptr->header.dword_2 = 0; |