diff options
| author | Sean Anderson <sean.anderson@seco.com> | 2024-02-01 13:18:51 -0500 |
|---|---|---|
| committer | Mattijs Korpershoek <mkorpershoek@baylibre.com> | 2024-02-09 09:42:04 +0100 |
| commit | 766f04a297e892d5106f7f7ac8b43c69bd8a6007 (patch) | |
| tree | 73d5e952238ff593eb312a226aa09a6ed2afc404 | |
| parent | ec19e113738ef6d689a43bff5f1ffc0e29def957 (diff) | |
| download | u-boot-766f04a297e892d5106f7f7ac8b43c69bd8a6007.zip u-boot-766f04a297e892d5106f7f7ac8b43c69bd8a6007.tar.gz u-boot-766f04a297e892d5106f7f7ac8b43c69bd8a6007.tar.bz2 | |
lib: sparse: Fix error checking for write_sparse_chunk_raw
The return value of write_sparse_chunk_raw is unsigned, so the existing
check has no effect. Use IS_ERR_VALUE to detect error instead, which is
what write_sparse_chunk_raw does itself.
Fixes: 62649165cb0 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/u-boot/1b323ec3-59b0-490b-a2f0-fd961dafcf49@moroto.mountain/
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Link: https://lore.kernel.org/r/20240201181851.221701-1-sean.anderson@seco.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
| -rw-r--r-- | lib/image-sparse.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/image-sparse.c b/lib/image-sparse.c index f828906..0922569 100644 --- a/lib/image-sparse.c +++ b/lib/image-sparse.c @@ -211,7 +211,7 @@ int write_sparse_image(struct sparse_storage *info, blks = write_sparse_chunk_raw(info, blk, blkcnt, data, response); - if (blks < 0) + if (IS_ERR_VALUE(blks)) return -1; blk += blks; |