diff options
author | Patrick Delaunay <patrick.delaunay@foss.st.com> | 2022-09-20 13:39:56 +0200 |
---|---|---|
committer | Patrice Chotard <patrice.chotard@foss.st.com> | 2022-12-12 11:25:19 +0100 |
commit | 91dae6d0a19e4d19715243487f0d0f8ca5b0c443 (patch) | |
tree | 18dcea4a86fc8db14652e57f921ef884da69ae8c | |
parent | 7a7b0856ca01f0dadc940f6f1bc6df44129ad9d0 (diff) | |
download | u-boot-91dae6d0a19e4d19715243487f0d0f8ca5b0c443.zip u-boot-91dae6d0a19e4d19715243487f0d0f8ca5b0c443.tar.gz u-boot-91dae6d0a19e4d19715243487f0d0f8ca5b0c443.tar.bz2 |
phy: usbphyc: use regulator_set_enable_if_allowed for disabling vbus supply
Use regulator_set_enable_if_allowed() api instead of regulator_set_enable()
while disabling vbus supply. This way the driver doesn't see an error
when it disable an always-on regulator for VBUS.
This patch is needed for STM32MP157C-DK2 board when the regulator
v3v3: buck4 used as the phy vbus supply in kernel device tree
is always on with the next hack for low power use-case:
&usbphyc_port0 {
...
/*
* Hack to keep hub active until all connected devices are suspended
* otherwise the hub will be powered off as soon as the v3v3 is disabled
* and it can disturb connected devices.
*/
connector {
compatible = "usb-a-connector";
vbus-supply = <&v3v3>;
};
};
Without this patch and the previous update in DT the command
"usb stop" failed and the next command "usb start" cause a crash.
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Reviewed-by: Marek Vasut <marex@denx.de>
-rw-r--r-- | drivers/phy/phy-stm32-usbphyc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/phy/phy-stm32-usbphyc.c b/drivers/phy/phy-stm32-usbphyc.c index 9f0b7d7..dcf2194 100644 --- a/drivers/phy/phy-stm32-usbphyc.c +++ b/drivers/phy/phy-stm32-usbphyc.c @@ -375,7 +375,7 @@ static int stm32_usbphyc_phy_power_off(struct phy *phy) return 0; if (usbphyc_phy->vbus) { - ret = regulator_set_enable(usbphyc_phy->vbus, false); + ret = regulator_set_enable_if_allowed(usbphyc_phy->vbus, false); if (ret) return ret; } |