diff options
author | Rasmus Villemoes <rasmus.villemoes@prevas.dk> | 2023-03-10 11:58:03 +0100 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2023-03-30 15:09:59 -0400 |
commit | 19213d7a65e9e3f8cfd0852599170636c894169e (patch) | |
tree | cd28b046cfbc8869c74b654a8498b3310b8784c3 | |
parent | 732b0825475c1a2466a6abf6e223b2a77af011f2 (diff) | |
download | u-boot-19213d7a65e9e3f8cfd0852599170636c894169e.zip u-boot-19213d7a65e9e3f8cfd0852599170636c894169e.tar.gz u-boot-19213d7a65e9e3f8cfd0852599170636c894169e.tar.bz2 |
sysinfo: gpio: fix loop over DT "revisions" array
There can certainly be a lot more elements in the "revisions" (and
"names") arrays than there are gpios used to form the trinary number
we're searching for; we simply don't know the array size up-front.
Nor do we need to, because the loop body already knows to recognize
-EOVERFLOW as "not that many elements present" (and we have a test
that specifically ensures that dev_read_u32_index() returns exactly
that). So just drop the i < priv->gpio_num condition.
While in here, fix the weird placement of the default: keyword.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Sean Anderson <sean.anderson@seco.com>
-rw-r--r-- | drivers/sysinfo/gpio.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/sysinfo/gpio.c b/drivers/sysinfo/gpio.c index 1d7f050..82f9030 100644 --- a/drivers/sysinfo/gpio.c +++ b/drivers/sysinfo/gpio.c @@ -57,7 +57,7 @@ static int sysinfo_gpio_get_str(struct udevice *dev, int id, size_t size, char * int i, ret; u32 revision; - for (i = 0; i < priv->gpio_num; i++) { + for (i = 0; ; i++) { ret = dev_read_u32_index(dev, "revisions", i, &revision); if (ret) { @@ -80,7 +80,8 @@ static int sysinfo_gpio_get_str(struct udevice *dev, int id, size_t size, char * strncpy(val, name, size); val[size - 1] = '\0'; return 0; - } default: + } + default: return -EINVAL; }; } |